Netdev List
 help / color / mirror / Atom feed
From: David Ahern <dsahern@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>, netdev@vger.kernel.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v3 iproute2-next] ip link: add sub-command to view and change DSA conduit interface
Date: Tue, 27 Sep 2022 21:16:34 -0600	[thread overview]
Message-ID: <8eb279e1-07e6-4326-7d81-8b7e4edc968a@kernel.org> (raw)
In-Reply-To: <20220922220655.2183524-1-vladimir.oltean@nxp.com>

On 9/22/22 3:06 PM, Vladimir Oltean wrote:
> Support the "dsa" kind of rtnl_link_ops exported by the kernel, and
> export reads/writes to IFLA_DSA_MASTER.
> 
> Examples:
> 
> $ ip link set swp0 type dsa conduit eth1
> 
> $ ip -d link show dev swp0
>     (...)
>     dsa conduit eth0
> 
> $ ip -d -j link show swp0
> [
> 	{
> 		"link": "eth1",
> 		"linkinfo": {
> 			"info_kind": "dsa",
> 			"info_data": {
> 				"conduit": "eth1"
> 			}
> 		},
> 	}
> ]
> 
> Note that by construction and as shown in the example, the IFLA_LINK
> reported by a DSA user port is identical to what is reported through
> IFLA_DSA_MASTER. However IFLA_LINK is not writable, and overloading its
> meaning to make it writable would clash with other users of IFLA_LINK
> (vlan etc) for which writing this property does not make sense.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
> v1->v2:
> - update man page
> v2->v3:
> - update main ip-link help text to print the new 'dsa' link type
> - rename the 'master' keyword to 'conduit' and keep 'master' as a
>   fallback
> - to avoid using the 'DSA master' term in the man page, stop explaining
>   which interfaces are eligible for this operation, and just refer to
>   the kernel documentation. Note that since the support was added in
>   net-next, the htmldocs have not been regenerated yet.
> 
>  include/uapi/linux/if_link.h | 10 ++++++

applied to iproute2-next.

always create patches against top of tree. had you done so I would not
have had to strip the uapi piece since it is already there.


  parent reply	other threads:[~2022-09-28  3:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22 22:06 [PATCH v3 iproute2-next] ip link: add sub-command to view and change DSA conduit interface Vladimir Oltean
2022-09-22 22:41 ` David Ahern
2022-09-28  3:16 ` David Ahern [this message]
2022-09-28  8:21   ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8eb279e1-07e6-4326-7d81-8b7e4edc968a@kernel.org \
    --to=dsahern@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=vivien.didelot@gmail.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox