From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH v3 iproute2 net-next] erspan: add erspan version II
 support
Date: Tue, 19 Dec 2017 18:28:24 -0700
Message-ID: <8eb4e84f-2218-0c96-ece6-2b1008f2da2f@gmail.com>
References: <1513732121-115044-1-git-send-email-u9012063@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
To: William Tu <u9012063@gmail.com>, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f41.google.com ([209.85.160.41]:37760 "EHLO
        mail-pl0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753041AbdLTB20 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 19 Dec 2017 20:28:26 -0500
Received: by mail-pl0-f41.google.com with SMTP id s3so8078535plp.4
        for <netdev@vger.kernel.org>; Tue, 19 Dec 2017 17:28:26 -0800 (PST)
In-Reply-To: <1513732121-115044-1-git-send-email-u9012063@gmail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hi William:

On 12/19/17 6:08 PM, William Tu wrote:
> @@ -343,6 +355,26 @@ get_failed:
>  				invarg("invalid erspan index\n", *argv);
>  			if (erspan_idx & ~((1<<20) - 1) || erspan_idx == 0)
>  				invarg("erspan index must be > 0 and <= 20-bit\n", *argv);
> +		} else if (strcmp(*argv, "erspan_ver") == 0) {
> +			NEXT_ARG();
> +			if (get_u8(&erspan_ver, *argv, 0))
> +				invarg("invalid erspan version\n", *argv);
> +			if (erspan_ver != 1 && erspan_ver != 2)
> +				invarg("erspan version must be 1 or 2\n", *argv);
> +		} else if (strcmp(*argv, "erspan_dir") == 0) {
> +			NEXT_ARG();
> +			if (strcmp(*argv, "ingress") == 0 ||
> +			    strcmp(*argv, "in") == 0)
> +				erspan_dir = 0;
> +			else if (strcmp(*argv, "egress") == 0 ||
> +				 strcmp(*argv, "e") == 0)

iproute2 has a matches() function that should be used -- it basically
allows whatever shorthand notation matches -- in this case e, eg, egr,
egres, egress all match. Checkout ip/iplink.c and search for matches.