From: Martin KaFai Lau <martin.lau@linux.dev>
To: Eyal Birger <eyal.birger@gmail.com>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
andrii@kernel.org, daniel@iogearbox.net,
nicolas.dichtel@6wind.com, razor@blackwall.org, mykolal@fb.com,
ast@kernel.org, song@kernel.org, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org, shuah@kernel.org
Subject: Re: [PATCH ipsec-next,v2 2/3] xfrm: interface: Add unstable helpers for setting/getting XFRM metadata from TC-BPF
Date: Thu, 1 Dec 2022 12:21:33 -0800 [thread overview]
Message-ID: <8ed7abe7-ebcb-766f-937e-793787578290@linux.dev> (raw)
In-Reply-To: <CAHsH6Gs4OajjoXauDw9zERx=+tUqpbpnP_8SxzmKKDQ3r8xmJA@mail.gmail.com>
On 11/30/22 9:55 PM, Eyal Birger wrote:
>>> +
>>> + info->if_id = from->if_id;
>>> + info->link = from->link;
>>> + skb_dst_force(skb);
>>> + info->dst_orig = skb_dst(skb);
>>> +
>>> + dst_hold((struct dst_entry *)md_dst);
>>> + skb_dst_set(skb, (struct dst_entry *)md_dst);
>>> + return 0;
>>> +}
>>> +
>>> +__diag_pop()
>>> +
>>> +BTF_SET8_START(xfrm_ifc_kfunc_set)
>>> +BTF_ID_FLAGS(func, bpf_skb_get_xfrm_info)
>>> +BTF_ID_FLAGS(func, bpf_skb_set_xfrm_info)
>>> +BTF_SET8_END(xfrm_ifc_kfunc_set)
>>> +
>>> +static const struct btf_kfunc_id_set xfrm_interface_kfunc_set = {
>>> + .owner = THIS_MODULE,
>>> + .set = &xfrm_ifc_kfunc_set,
>>> +};
>>> +
>>> +int __init register_xfrm_interface_bpf(void)
>>> +{
>>> + int err;
>>> +
>>> + xfrm_md_dst = metadata_dst_alloc_percpu(0, METADATA_XFRM,
>>> + GFP_KERNEL);
>>
>> May be DEFINE_PER_CPU() instead?
>
> Are you suggesting duplicating the dst init/cleanup logic here?
> Personally given that this happens once at module load, I think it's best to
> use the existing infrastructure, but am willing to add this here if you think
> it's better.
Agree, staying with the current patch is better. I somehow thought
metadata_dst_alloc_percpu() was newly added in this patch also.
next prev parent reply other threads:[~2022-12-01 20:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 13:20 [PATCH ipsec-next,v2 0/3] xfrm: interface: Add unstable helpers for XFRM metadata Eyal Birger
2022-11-29 13:20 ` [PATCH ipsec-next,v2 1/3] xfrm: interface: rename xfrm_interface.c to xfrm_interface_core.c Eyal Birger
2022-11-29 13:20 ` [PATCH ipsec-next,v2 2/3] xfrm: interface: Add unstable helpers for setting/getting XFRM metadata from TC-BPF Eyal Birger
2022-11-30 18:14 ` Martin KaFai Lau
2022-12-01 5:55 ` Eyal Birger
2022-12-01 13:30 ` Eyal Birger
2022-12-01 20:18 ` Martin KaFai Lau
2022-12-01 20:47 ` Eyal Birger
2022-12-01 20:21 ` Martin KaFai Lau [this message]
2022-11-29 13:20 ` [PATCH ipsec-next,v2 3/3] selftests/bpf: add xfrm_info tests Eyal Birger
2022-11-30 18:41 ` Martin KaFai Lau
2022-11-30 18:48 ` Martin KaFai Lau
2022-12-01 5:34 ` Eyal Birger
2022-12-01 7:33 ` Martin KaFai Lau
2022-12-01 13:33 ` Eyal Birger
2022-12-01 20:26 ` Martin KaFai Lau
2022-12-01 20:48 ` Eyal Birger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ed7abe7-ebcb-766f-937e-793787578290@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eyal.birger@gmail.com \
--cc=haoluo@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mykolal@fb.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).