From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next v3] Add Common Applications Kept Enhanced (cake) qdisc Date: Wed, 25 Apr 2018 09:59:52 -0700 Message-ID: <8ed8d136-1eac-82c0-bf2e-02be697729f2@gmail.com> References: <20180425134249.21300-1-toke@toke.dk> <878t9b5n0q.fsf@toke.dk> <6bc11ded-028f-6c8f-964e-a569b4e10813@gmail.com> <8736zj6zj2.fsf@toke.dk> <8bae2ee1-efcc-1571-2a30-5b7779de2c88@gmail.com> <87tvrz5ipt.fsf@toke.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: cake@lists.bufferbloat.net, Dave Taht To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , Eric Dumazet , netdev@vger.kernel.org Return-path: Received: from mail-pf0-f181.google.com ([209.85.192.181]:40686 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754618AbeDYQ7y (ORCPT ); Wed, 25 Apr 2018 12:59:54 -0400 Received: by mail-pf0-f181.google.com with SMTP id f189so6632470pfa.7 for ; Wed, 25 Apr 2018 09:59:54 -0700 (PDT) In-Reply-To: <87tvrz5ipt.fsf@toke.dk> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 04/25/2018 09:55 AM, Toke Høiland-Jørgensen wrote: > Well, as I said, 10Gbit+ links are not really the target audience ;) Well, 640KB of memory is all we need. > > We did actually have a threshold at some point, but it was removed > because it didn't work well (I'm not sure of the details, perhaps > someone else will chime in). > > However, I'm fine with adding a flag, as long as peeling defaults to on, > at least when the shaper is active (to properly account for packet > overhead we really need to see every packet that goes out on the wire). > Would that be acceptable? Not a flag, a threshold based on bandwidth.