From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B8A9C6FD1D for ; Tue, 21 Mar 2023 13:33:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229475AbjCUNdF (ORCPT ); Tue, 21 Mar 2023 09:33:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229942AbjCUNdE (ORCPT ); Tue, 21 Mar 2023 09:33:04 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 339B3C64F for ; Tue, 21 Mar 2023 06:32:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679405536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XAb2uxPKaKIV+ehim9J4b/qc8T7HsQ8APwR4QoSZVhY=; b=Sm1NUt2fQPvKezxl9wrND4JpjEv6ggr3oW0PEaQgZMoGOTsKP0MbEzIijB1bxlPZv+drdC l57EoyZTO3Oopd0JTq1sZaWh7dfsPuTORIsFy4UIphspjG7uGSykf+z9wjZnKSiQWNklnr uOtmo0pfwdlP2tttV7aXhELuMayuMf8= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-183-jiej1XtmNOyPrUerVr398w-1; Tue, 21 Mar 2023 09:32:11 -0400 X-MC-Unique: jiej1XtmNOyPrUerVr398w-1 Received: by mail-ed1-f69.google.com with SMTP id k12-20020a50c8cc000000b004accf30f6d3so22064993edh.14 for ; Tue, 21 Mar 2023 06:32:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679405529; h=content-transfer-encoding:in-reply-to:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XAb2uxPKaKIV+ehim9J4b/qc8T7HsQ8APwR4QoSZVhY=; b=FtXDBBRgm6nO+xM0hwUb/bfGVJbF1vl2i3mPomEq5ZMMGH3oRAxq1jEnFjbglbacmP oVSt5bsl2iWkbGOhGvCKvT67mlNOa3Xp9dto4n2PaCig2HofQHha6LFOXqEgvPoIcnGb P3se6qA5Tl5wynx86zVAZhNzDsE9YSvwyCBYTa/1O4R0yRPCr/5tmpgFv7Cv/XfdPYvI 3FNrlv2dA4H6H2g2fYFSM71hWznxXlnFZAMdBYnIIiCepXfZh2n5g6htdaoCBbTSIn/0 kDfsDW8kwip50A+vjyiundTq/FbFSE0MsfMVKzBcBDU/vKJXCscxZCboAsQ8uhBIRhCu AE8w== X-Gm-Message-State: AO0yUKX64g24dn64elagqk3mrMNJNbilJt4yjpyQrLlEz525fcIG+gzQ 29XGdCtSepASlpu1p7H47+COl22s6trHpmKV5ry/XAdKIsVrDyjrI2x29Oa+xJooLvIKPRmZgvt 4KkMs8HFLDI1qZE5/ X-Received: by 2002:a17:906:14c2:b0:932:35b1:47f8 with SMTP id y2-20020a17090614c200b0093235b147f8mr2654428ejc.34.1679405529044; Tue, 21 Mar 2023 06:32:09 -0700 (PDT) X-Google-Smtp-Source: AK7set81J2bqWCjI8tdWygfhO8d83WHUen2iHUass/RxzdNgyGmELyDyU0u1VQUNZ+2byG3sKFHSwg== X-Received: by 2002:a17:906:14c2:b0:932:35b1:47f8 with SMTP id y2-20020a17090614c200b0093235b147f8mr2654413ejc.34.1679405528787; Tue, 21 Mar 2023 06:32:08 -0700 (PDT) Received: from [192.168.42.100] (194-45-78-10.static.kviknet.net. [194.45.78.10]) by smtp.gmail.com with ESMTPSA id lt11-20020a170906fa8b00b008e54ac90de1sm5790753ejb.74.2023.03.21.06.32.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Mar 2023 06:32:08 -0700 (PDT) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Message-ID: <8edd0206-0f2a-d5e7-27de-a0a9cc92526e@redhat.com> Date: Tue, 21 Mar 2023 14:32:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Cc: brouer@redhat.com, bpf@vger.kernel.org, netdev@vger.kernel.org, martin.lau@kernel.org, ast@kernel.org, daniel@iogearbox.net, alexandr.lobakin@intel.com, larysa.zaremba@intel.com, xdp-hints@xdp-project.net, anthony.l.nguyen@intel.com, yoong.siang.song@intel.com, boon.leong.ong@intel.com Subject: Re: [PATCH bpf-next V1 4/7] selftests/bpf: xdp_hw_metadata RX hash return code info Content-Language: en-US To: Stanislav Fomichev References: <167906343576.2706833.17489167761084071890.stgit@firesoul> <167906361094.2706833.8381428662566265476.stgit@firesoul> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 17/03/2023 22.13, Stanislav Fomichev wrote: > On 03/17, Jesper Dangaard Brouer wrote: >> When driver developers add XDP-hints kfuncs for RX hash it is >> practical to print the return code in bpf_printk trace pipe log. > >> Print hash value as a hex value, both AF_XDP userspace and bpf_prog, >> as this makes it easier to spot poor quality hashes. > >> Signed-off-by: Jesper Dangaard Brouer > > Acked-by: Stanislav Fomichev > > (with a small suggestion below, maybe can do separately?) > >> --- >>   .../testing/selftests/bpf/progs/xdp_hw_metadata.c  |    9 ++++++--- >>   tools/testing/selftests/bpf/xdp_hw_metadata.c      |    5 ++++- >>   2 files changed, 10 insertions(+), 4 deletions(-) [...] >> diff --git a/tools/testing/selftests/bpf/xdp_hw_metadata.c >> b/tools/testing/selftests/bpf/xdp_hw_metadata.c >> index 400bfe19abfe..f3ec07ccdc95 100644 >> --- a/tools/testing/selftests/bpf/xdp_hw_metadata.c >> +++ b/tools/testing/selftests/bpf/xdp_hw_metadata.c >> @@ -3,6 +3,9 @@ >>   /* Reference program for verifying XDP metadata on real HW. >> Functional test >>    * only, doesn't test the performance. >>    * > > [..] > >> + * BPF-prog bpf_printk info outout can be access via >> + * /sys/kernel/debug/tracing/trace_pipe > > Maybe we should just dump the contents of > /sys/kernel/debug/tracing/trace for every poll cycle? > I think this belongs to a separate patch. > We can also maybe enable tracing in this program transparently? > I usually forget 'echo 1 > > /sys/kernel/debug/tracing/events/bpf_trace/bpf_trace_printk/enable' > myself :-) > What is this trick? --Jesper