From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD209215F58 for ; Thu, 12 Dec 2024 14:56:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734015404; cv=none; b=qCoH7RO+2/g/rMQKxrtN3DALSldBLxvG+vLEIYUBt0kPokoWAc+1mkqxxZHG2pmnH79HR6nuU8dS8ickSlYkTtwaqTZsjZQZUU+7xGq1mM+wccrJ1K9QC62clELzQDQNT4NZdqlLoBk3qbwKTrgWvP65ahtyFAq3iPYtPFVW+28= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734015404; c=relaxed/simple; bh=AjQOAHstwlMlrDDeDDeSx0eAGZcKzvIvjK1+noRizkA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aiy8u4QvYT1YgPhXRWGFAPKj3Aufey1/1dOO0kBSM9HCrlJndTKpM+/TU0K3PyHWYoZci8g0QGi0rpSGv5OXuX9CcgGkdidufDKG80n9WC441HaijonU33kY9rGlz4DSjN+nKHmJDgnCUjrxixPXzrLLSZtICp+3blrWc9SHnYI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Z8VES4Pj; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z8VES4Pj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734015400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oL7oDzf/iu+owBEyFgADY3KtJbecvvlrXRMt6TBS380=; b=Z8VES4Pj+BPL3rTWozqlBCnrxxAPRj/mVomiH5hVtP0GPAsYLNeKVMB+e2k2bVladsC6Li pQfKGJ7TVbdYsicCzPRBf2PCww0sWqv3DMGsQj4KSzU46zOt9u8GlZs3Akw9yPqhMO25M4 BEYemcGBMxud0H1YdeMsvXpC4R8eLDw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-yHly0fkjPLGaDRGXtFxuXg-1; Thu, 12 Dec 2024 09:56:38 -0500 X-MC-Unique: yHly0fkjPLGaDRGXtFxuXg-1 X-Mimecast-MFC-AGG-ID: yHly0fkjPLGaDRGXtFxuXg Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43621907030so7205505e9.1 for ; Thu, 12 Dec 2024 06:56:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734015397; x=1734620197; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oL7oDzf/iu+owBEyFgADY3KtJbecvvlrXRMt6TBS380=; b=ZrW7p4gI3o9k9txxGwCDHVwEZE18bqSP88ppDYgjUh9ba+R5lsZXKQFXjOtAA/WbmW svuMFNJUMOwq0JgLX4dRLLkf4lxpwDa6xnZtjQYUyaV4g9MCcQSGwnDoUHEwD3J1DO5G LtLJW2YP3k6u5fCbPoial3G1W/EvfsK0rnS99euwfd/66L7Qh5NjBKTR9+ygftBQ6hez 2nqRQZbhpOW7gkoz6Ox5DzDo7Btgga8HBYyaaiw4IXzO01Iwyb8MU762FbD/SG3B5nGB zxT3M4NI1zE3639IwOxv/um65kEYdS6KnQfy7ZSj6inADjL3oSvnLSaBS0k2z4WOuvTl 5gnA== X-Forwarded-Encrypted: i=1; AJvYcCXH5uxkPXRhbaE3+0Y2XZvbG8uBRbh/xKVfvcOkejOZF53zbL66Gu1JplsMDr1iIeS/PzfkcU4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+47ne8JKUsIorMnFrCc0dWP7CocqBFLk33NcrKPOuF/hM7akS UeXXz0lgdQFSlIh/xZ8kiu2FbeEbAWqWUbXuf/XTNoUs8WLS8oUlX9FUgddZTQapVPg85GoWZtz nr83LYwFzK7tMpn0Yqpu6SYa4MPjQGVnhQvWJmkKUdC4h1mh0cEWX+g== X-Gm-Gg: ASbGncs5ChUMKnrw12U29JRFGPx3K0KrJAIDzt+Mje1iqWnbqf4scC8ZUJwcwTgcc+z xgGds92veq0etinLI1zOf12fp+jRJeqQmUohDnTlveU2ZBPmKOLWBj0nuqSSwYHts/zyGJG1Mgz kIqWvXJZXWNCT1dsC4aDk1EeDns4qJfX1WaK+ize58++LzZmzVNw5I7f8DKHw8vyH+IqC9TDDMG fpmpAFmTU0NXXpG9JoaK28jmzbv87M/gHRJS0Gehjmz3ZZVhL9UatEIchOpa+Dqmm4mMKolUNSK Ipyl2Qg= X-Received: by 2002:a05:600c:34cc:b0:434:fbe2:4f with SMTP id 5b1f17b1804b1-4361c430b5cmr63303045e9.23.1734015397041; Thu, 12 Dec 2024 06:56:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IH6jT4MvcNP0dxPJ6BKwDHdX4PrfqhYHXR4TAbgRNM6khL6oXpHiVnh7UfEpSYX/vLofOsSxA== X-Received: by 2002:a05:600c:34cc:b0:434:fbe2:4f with SMTP id 5b1f17b1804b1-4361c430b5cmr63302405e9.23.1734015396688; Thu, 12 Dec 2024 06:56:36 -0800 (PST) Received: from [192.168.88.24] (146-241-48-67.dyn.eolo.it. [146.241.48.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4362557c457sm19247805e9.15.2024.12.12.06.56.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Dec 2024 06:56:36 -0800 (PST) Message-ID: <8ee0cf91-c215-4015-90fc-32be6f22b7db@redhat.com> Date: Thu, 12 Dec 2024 15:56:32 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 03/11] net/ethernet: Use never-managed version of pci_intx() To: Philipp Stanner , amien Le Moal , Niklas Cassel , Basavaraj Natikar , Jiri Kosina , Benjamin Tissoires , Arnd Bergmann , Greg Kroah-Hartman , Alex Dubov , Sudarsana Kalluru , Manish Chopra , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Rasesh Mody , GR-Linux-NIC-Dev@marvell.com, Igor Mitsyanko , Sergey Matyukevich , Kalle Valo , Sanjay R Mehta , Shyam Sundar S K , Jon Mason , Dave Jiang , Allen Hubbe , Bjorn Helgaas , Alex Williamson , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Mario Limonciello , Chen Ni , Ricky Wu , Al Viro , Breno Leitao , Thomas Gleixner , Kevin Tian , Andy Shevchenko , Mostafa Saleh , Jason Gunthorpe , Yi Liu , Kunwu Chan , Dan Carpenter , "Dr. David Alan Gilbert" , Ankit Agrawal , Reinette Chatre , Eric Auger , Ye Bin Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ntb@lists.linux.dev, linux-pci@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org References: <20241209130632.132074-2-pstanner@redhat.com> <20241209130632.132074-5-pstanner@redhat.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20241209130632.132074-5-pstanner@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/9/24 14:06, Philipp Stanner wrote: > pci_intx() is a hybrid function which can sometimes be managed through > devres. To remove this hybrid nature from pci_intx(), it is necessary to > port users to either an always-managed or a never-managed version. > > broadcom/bnx2x and brocade/bna enable their PCI-Device with > pci_enable_device(). Thus, they need the never-managed version. > > Replace pci_intx() with pci_intx_unmanaged(). > > Signed-off-by: Philipp Stanner Acked-by: Paolo Abeni