From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiner Kallweit Subject: Re: [PATCH net-next 02/10] r8169: use phy_resume/phy_suspend Date: Mon, 2 Jul 2018 23:24:32 +0200 Message-ID: <8ef120d3-ac4a-7ffd-2104-76d6f1268105@gmail.com> References: <096a5326-963c-9bef-6218-29fcde004111@gmail.com> <318ae669-d89c-636d-94ac-d4c9f662400e@gmail.com> <20180702210646.GB12564@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: David Miller , Florian Fainelli , Realtek linux nic maintainers , "netdev@vger.kernel.org" To: Andrew Lunn Return-path: Received: from mail-wr0-f193.google.com ([209.85.128.193]:37790 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753349AbeGBVYn (ORCPT ); Mon, 2 Jul 2018 17:24:43 -0400 Received: by mail-wr0-f193.google.com with SMTP id q10-v6so2138109wrd.4 for ; Mon, 02 Jul 2018 14:24:41 -0700 (PDT) In-Reply-To: <20180702210646.GB12564@lunn.ch> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 02.07.2018 23:06, Andrew Lunn wrote: >> static void r8168_pll_power_down(struct rtl8169_private *tp) >> { >> if (r8168_check_dash(tp)) >> @@ -4510,7 +4469,8 @@ static void r8168_pll_power_down(struct rtl8169_private *tp) >> if (rtl_wol_pll_power_down(tp)) >> return; >> >> - r8168_phy_power_down(tp); >> + /* cover the case that PHY isn't connected */ >> + phy_suspend(mdiobus_get_phy(tp->mii_bus, 0)); > > This could do some more explanation. Why would it not be connected? > The PHY gets connected when the net_device is opened. If a network port isn't used then it will be runtime-suspended a few seconds after boot. In this case we call r8168_pll_power_down() with the PHY not being connected. > Andrew >