From: Paolo Abeni <pabeni@redhat.com>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next] net: add prefetch() in skb_defer_free_flush()
Date: Thu, 6 Nov 2025 10:05:13 +0100 [thread overview]
Message-ID: <8ef591e6-9b05-4c7b-8d75-82ced4dd2f31@redhat.com> (raw)
In-Reply-To: <20251106085500.2438951-1-edumazet@google.com>
On 11/6/25 9:55 AM, Eric Dumazet wrote:
> skb_defer_free_flush() is becoming more important these days.
>
> Add a prefetch operation to reduce latency a bit on some
> platforms like AMD EPYC 7B12.
>
> On more recent cpus, a stall happens when reading skb_shinfo().
> Avoiding it will require a more elaborate strategy.
For my education, how do you catch such stalls? looking for specific
perf events? Or just based on cycles spent in a given function/chunk of
code?
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Just to avoid doubts on my thoughts about this patch:
Acked-by: Paolo Abeni <pabeni@redhat.com>
next prev parent reply other threads:[~2025-11-06 9:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 8:55 [PATCH net-next] net: add prefetch() in skb_defer_free_flush() Eric Dumazet
2025-11-06 9:05 ` Paolo Abeni [this message]
2025-11-06 9:13 ` Eric Dumazet
2025-11-06 15:04 ` Paolo Abeni
2025-11-08 3:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ef591e6-9b05-4c7b-8d75-82ced4dd2f31@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox