netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, xiyou.wangcong@gmail.com
Subject: Re: [PATCH v2 net-next] tcp: Check daddr_cache before use in tracepoint
Date: Wed, 18 Oct 2017 08:54:10 -0600	[thread overview]
Message-ID: <8f1c0c37-e39d-de47-f4f8-5d76e36ddfb1@gmail.com> (raw)
In-Reply-To: <20171018.141540.2101290573491932828.davem@davemloft.net>

On 10/18/17 7:15 AM, David Miller wrote:
> From: David Ahern <dsahern@gmail.com>
> Date: Mon, 16 Oct 2017 15:32:07 -0700
> 
>> Running perf in one window to capture tcp_retransmit_skb tracepoint:
>>     $ perf record -e tcp:tcp_retransmit_skb -a
>>
>> And causing a retransmission on an active TCP session (e.g., dropping
>> packets in the receiver, changing MTU on the interface to 500 and back
>> to 1500) triggers a panic:
>  ...
>> Check that daddr_cache is non-NULL before de-referencing.
>>
>> Fixes: e086101b150a ("tcp: add a tracepoint for tcp retransmission")
>> Signed-off-by: David Ahern <dsahern@gmail.com>
> 
> Applied.
> 

Hi Dave: There was a v3 to this one. I'll send a diff patch.

      reply	other threads:[~2017-10-18 14:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16 22:32 [PATCH v2 net-next] tcp: Check daddr_cache before use in tracepoint David Ahern
2017-10-16 22:35 ` Cong Wang
2017-10-18 13:15 ` David Miller
2017-10-18 14:54   ` David Ahern [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f1c0c37-e39d-de47-f4f8-5d76e36ddfb1@gmail.com \
    --to=dsahern@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).