From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 477B1C43381 for ; Thu, 14 Feb 2019 19:10:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1326C222D0 for ; Thu, 14 Feb 2019 19:10:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lHb5XSgR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438267AbfBNTKs (ORCPT ); Thu, 14 Feb 2019 14:10:48 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:37936 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388100AbfBNTKs (ORCPT ); Thu, 14 Feb 2019 14:10:48 -0500 Received: by mail-pf1-f196.google.com with SMTP id q1so3561765pfi.5 for ; Thu, 14 Feb 2019 11:10:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=b+0UZOGSeZKZmiUZnMOFM0QU1XBesV28HtuvG2ddA9A=; b=lHb5XSgRK3lFz4N3ZwD9Z4Kz7eywnS5Hv5kr7WN+FHmG74hzxd1KwHJS8x+5njgFHv WD0td/FpIAXR+glhkPwwGRPvVNTAPYoeRLISEh1BPqQYwvTkK2cBFoZeEYzho9Fs2BML Wn0qffL0jb6M+CV3oq+eCfCQw7tEQl6IIP6Gv4SObTHAuDHUxx1JM4FcrvN0zIFoSGAh GTm9nM8E5s7AXwWLX+rrY5cEc3CTsLIdTvKrov7G1zDogBeQ6Sv0AKQ9nKDHgRu0hRuh XXgYswR6EoCbzSmCPoFAFaUv38CpbGZaz69Wt0h0F9jiZdCywOqTBPjO3IMWoN6JHSDD D9HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=b+0UZOGSeZKZmiUZnMOFM0QU1XBesV28HtuvG2ddA9A=; b=k4zpkAzGaWXIG7omBytBgIkoguaTEgJC3/dFFLiFaiAQv8y+HNC3W7xVuustd51I5+ eq4SOghMINtokcZayUJnZOJxvWg9dDw1ipokF9k/biBzmrC+86yz3NBr7t3GxvDuspnQ YbNhCWe4JDTnMPLjhpxOChmkY76ICS0OO6usDZLY3b2cdKFeOg1HGc++MFHhup+prrlK ZmL9QE5wE2NQFgK4wcj9kpmT2wN6owJhxvAsrqZDeHgF1tQUxZch0uuIyWT7HCCFETJQ DhvNk4Ou+3paT2MNd/dGK8x50xMs1d+aj8AxxKL+zma1Y6lepunNX9+b/734QOZYbFNr e04A== X-Gm-Message-State: AHQUAuYc4B+d84kdKTY9msMzfIrbJ9KhAdY6STCu03Vjb4C9d/Qk9loR CcIkW9B3YyO4sAaUNYWO7jk= X-Google-Smtp-Source: AHgI3IbB1AOlvrYAoO3KzAVYivhTmO1m8KaCAXUMByC4i4EoIRrWSIS6MKbpyYM6QcaxBNoICj4ieg== X-Received: by 2002:a63:c345:: with SMTP id e5mr1397703pgd.103.1550171447607; Thu, 14 Feb 2019 11:10:47 -0800 (PST) Received: from ?IPv6:2601:282:800:fd80:fcca:3d2d:5c58:2370? ([2601:282:800:fd80:fcca:3d2d:5c58:2370]) by smtp.googlemail.com with ESMTPSA id e26sm3779137pfi.70.2019.02.14.11.10.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Feb 2019 11:10:46 -0800 (PST) Subject: Re: [PATCH bpf-next] bpf: fix memory leak in bpf_lwt_xmit_reroute To: Peter Oskolkov Cc: Peter Oskolkov , Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org, Willem de Bruijn References: <20190214060939.101851-1-posk@google.com> <733c9f8e-2262-dbff-6aa6-f960983812ab@gmail.com> From: David Ahern Message-ID: <8f52efda-b502-2bfb-c881-8833bac461c2@gmail.com> Date: Thu, 14 Feb 2019 12:10:45 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/14/19 11:42 AM, Peter Oskolkov wrote: > I'll refactor the test as you suggest here > when I add VRF and GRO tests in a couple of weeks, if this is OK. IMO, the tests should go in with the feature, not a release later. If we are at -rc6 this week then you might get next week as well. The unreachable toggle is a fairly quick integration. GRO really should also get in the same cycle as the feature. Preferably VRF tests as well since you have the commands. The pretty printing cleanup can be done later.