From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 580FB31A79 for ; Fri, 5 Jan 2024 16:22:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=6wind.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=6wind.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=6wind.com header.i=@6wind.com header.b="NB1mN6Ds" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-40d5336986cso19383975e9.1 for ; Fri, 05 Jan 2024 08:22:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; t=1704471753; x=1705076553; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:reply-to:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=lomhMQTQuknXyilv/6O1Ig9F6eSFk3s039swGnXqBac=; b=NB1mN6DskExGrZ/j6pr6BfQkTB0pct+lUNMG8xewEypuxaoDfenelXMLkTYuqKP2YO iKSyqP7RxJhgKzh+f8sJatuV0x+juf086CTnN8hExscbZhLrY2kLE3pH5HiAEquNBUXx 4YMndGXB3RomNooaOKj+NX3wBmAq2dEVtNHK4tnx5SEl+Ogqa/Fs0Q/iXsldOiDUFeOp 8Q1Rj5d0ULxEnmz76BcM/sNG1jMOhgb8o8F0dU05CixezoI0XJFU8cAnC8JTlrX0Dc3f 1mWWEKfQcsc4mdcAqBdtD0WyDmGwhEQO/56rasEhcnnuln40BZtoGJiv1H3wI4bQA4hW 10NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704471753; x=1705076553; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:reply-to:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lomhMQTQuknXyilv/6O1Ig9F6eSFk3s039swGnXqBac=; b=RTSoAB5SJTP4bI3v5Ce9qW37CCEdS43CIj6Vj6wGsNCJT1s1U6yzbu4xZ26uvQjHkf qJ8xAATA/LiI72kVNeX6zOfrazNjkXFVQ4hT6tudA3RMcsq33zBEWhpuqvR5gbUhEIT4 Qq5b9AJpId09BNHzuWT8V6fC5FxkXhWBUoPHru+Kq06wS7nx9g/za1WfoFY4aSm0ATK7 AdXvX6duh3mNVvwIqeiqWNu/amByreVlxoNnA8sMIKPZqhoEDohIO1vM0xyr+4W4YrZ5 nfUOnIYy4pAwgiCRXr545gt5nTEA+0a439mwC71OKzQpus28Kc2+8cQ/NM4Jkr7pipmH Gy/A== X-Gm-Message-State: AOJu0YzowPdof5x/0SYagjtujlGtDTmIjx3BgDc9eS849GXMReP05/Pi xUMW+S4/MJr+SwfExb4to/OFuEtrksqwgQ== X-Google-Smtp-Source: AGHT+IEgScjy5H+C5xtCpxZ33SYU+9VkmzyQvPVmiUjMUyLQjOmHkjbCAMr0Ip7uj2urEdGH2vNv5g== X-Received: by 2002:a1c:7404:0:b0:40d:5a9c:f2e8 with SMTP id p4-20020a1c7404000000b0040d5a9cf2e8mr1116114wmc.174.1704471753533; Fri, 05 Jan 2024 08:22:33 -0800 (PST) Received: from ?IPV6:2a01:e0a:b41:c160:144d:d8d:d728:b78b? ([2a01:e0a:b41:c160:144d:d8d:d728:b78b]) by smtp.gmail.com with ESMTPSA id l3-20020a05600c4f0300b0040d8d11bd4esm2026741wmq.36.2024.01.05.08.22.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jan 2024 08:22:32 -0800 (PST) Message-ID: <8f5f1e0b-da1b-4b3e-8e55-33e46556ddc5@6wind.com> Date: Fri, 5 Jan 2024 17:22:31 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: nicolas.dichtel@6wind.com Subject: Re: [PATCH net v3 1/2] rtnetlink: allow to set iface down before enslaving it Content-Language: en-US To: Jiri Pirko Cc: "David S . Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , Phil Sutter , David Ahern , netdev@vger.kernel.org, stable@vger.kernel.org References: <20240104164300.3870209-1-nicolas.dichtel@6wind.com> <20240104164300.3870209-2-nicolas.dichtel@6wind.com> From: Nicolas Dichtel Organization: 6WIND In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Le 05/01/2024 à 12:59, Jiri Pirko a écrit : > Thu, Jan 04, 2024 at 05:42:59PM CET, nicolas.dichtel@6wind.com wrote: >> The below commit adds support for: >>> ip link set dummy0 down >>> ip link set dummy0 master bond0 up >> >> but breaks the opposite: >>> ip link set dummy0 up >>> ip link set dummy0 master bond0 down > > It is a bit weird to see these 2 and assume some ordering. > The first one assumes: > dummy0 master bond 0, dummy0 up > The second one assumes: > dummy0 down, dummy0 master bond 0 > But why? > > What is the practival reason for a4abfa627c38 existence? I mean, > bond/team bring up the device themselfs when needed. Phil? > Wouldn't simple revert do better job here? Yeah, I assumed there was a good reason, but you're right. > > >> >> Let's add a workaround to have both commands working. >> >> Cc: stable@vger.kernel.org >> Fixes: a4abfa627c38 ("net: rtnetlink: Enslave device before bringing it up") >> Signed-off-by: Nicolas Dichtel >> Acked-by: Phil Sutter >> Reviewed-by: David Ahern >> --- >> net/core/rtnetlink.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c >> index e8431c6c8490..dd79693c2d91 100644 >> --- a/net/core/rtnetlink.c >> +++ b/net/core/rtnetlink.c >> @@ -2905,6 +2905,14 @@ static int do_setlink(const struct sk_buff *skb, >> call_netdevice_notifiers(NETDEV_CHANGEADDR, dev); >> } >> >> + /* Backward compat: enable to set interface down before enslaving it */ >> + if (!(ifm->ifi_flags & IFF_UP) && ifm->ifi_change & IFF_UP) { >> + err = dev_change_flags(dev, rtnl_dev_combine_flags(dev, ifm), >> + extack); >> + if (err < 0) >> + goto errout; >> + } >> + >> if (tb[IFLA_MASTER]) { >> err = do_set_master(dev, nla_get_u32(tb[IFLA_MASTER]), extack); >> if (err) >> -- >> 2.39.2 >> >>