From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E362923C50A; Wed, 11 Mar 2026 18:10:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773252625; cv=none; b=vAP+ZfjmqzQcMfFHMuHf8p10szEmp+UH2nCMy8paOctv+BPV0nFvSfpJOqlcAnOEsg+EDP1f3L80a700cZ5G3UMizaobDnct08998uNBQDgY83CvfmAymGcnbKxbfhejLQHz/1IpClm4ygTSYlYK3nwCJF8ASc2ZvBlf826XRfI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773252625; c=relaxed/simple; bh=fX97InEG2Y/bHlqZFQqzPwU7oz0ha1RwbkrWCs4lWas=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KYBUdehEk31UHk65SEtMnsQPawo0fGNm/XnC+jv7txn7l1nVP5yfAB8gPWVqH/HanjkOhOBtXFlrz7tA+TovDKVjMrGG+NFV6HoBC026gcParkJcZwx4n3jR4rmTrtFou2jGUFr5ac+hF+46/N3HchqIeMRopfcDetYyIhp1dko= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KtH96U9G; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KtH96U9G" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E204C4CEF7; Wed, 11 Mar 2026 18:10:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773252624; bh=fX97InEG2Y/bHlqZFQqzPwU7oz0ha1RwbkrWCs4lWas=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KtH96U9GUOZyJ/lj7WtbQSyJr21mPmZuMIGeMhm/E+9z8uhRCV9HT5VoxIhQsXQPC 5482lcmlJbnDEwaUAnWxZFirHLT/HBNJB6grmAvGz5yQXz0MTe4FSar/OcsedMoQ+7 kpvLDu9s5NkxWrYaSNgShVcNL5lBV3aeQeyuhkXn/csPSj1JwBVJ28COEXhCnrzVpZ fp/NlLOTbVO8IysIfhzva3qVlXVSebToikFVoxAiPuQVT1DQ2qaawZRg0cp/2q5ajm Oyf2DwAPtdiGowzzBJ13RXMYgS/+eZXmCS+8Grj9G9Zn8uOTofCN1yYn/vpjDzoE3Y c06klwjMg07yw== Message-ID: <8f6eb4f0-50b7-4894-b990-98563f1e6b3b@kernel.org> Date: Wed, 11 Mar 2026 19:10:09 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 03/10] dt-bindings: net: cdns,macb: replace cdns,refclk-ext with cdns,refclk-source To: Conor Dooley Cc: netdev@vger.kernel.org, Conor Dooley , Valentina.FernandezAlanis@microchip.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Daire McNamara , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Nicolas Ferre , Claudiu Beznea , Richard Cochran , Samuel Holland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Dave Stevenson , Sean Anderson , Vineeth Karumanchi , Abin Joseph , =?UTF-8?Q?Th=C3=A9o_Lebrun?= , Ryan.Wanner@microchip.com References: <20260310-moneyless-dispense-7bce14b16388@spud> <20260310-sneak-handclap-c150d8f1236b@spud> <20260311-horned-dexterous-caribou-3a46fb@quoll> <20260311-rival-kerosene-81d12381d120@spud> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20260311-rival-kerosene-81d12381d120@spud> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/03/2026 19:08, Conor Dooley wrote: > On Wed, Mar 11, 2026 at 08:00:54AM +0100, Krzysztof Kozlowski wrote: >> On Tue, Mar 10, 2026 at 05:17:10PM +0000, Conor Dooley wrote: >>> From: Conor Dooley >>> >>> Ryan added cdns,refclk-ext with the intent of decoupling the source of >>> the reference clock on sama7g5 (and related platforms) from the >>> compatible. Unfortunately, the default for sama7g5-emac is an external >>> reference clock, so this property had no effect there, so that >>> compatibility with older devicetrees is preserved. >>> Replace cdns,refclk-ext with one that supports both default states and >>> therefore is usable for sama7g5-emac. >>> >>> For now, limit it to only the platforms that have USRIO controlled >>> reference clock selection, but this could be generalised in the future. >>> >>> Signed-off-by: Conor Dooley >>> --- >>> .../devicetree/bindings/net/cdns,macb.yaml | 39 ++++++++++++++++--- >>> 1 file changed, 34 insertions(+), 5 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml >>> index cb14c35ba9969..a492357570edd 100644 >>> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml >>> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml >>> @@ -120,12 +120,14 @@ properties: >>> power-domains: >>> maxItems: 1 >>> >>> - cdns,refclk-ext: >>> - type: boolean >> >> This is already an implemented ABI, so you cannot drop it even if some >> devices works fine on default. Instead please deprecate it and keep >> drivers backwards compatible for whoever is using it. > > The driver still will support it for those devices, but I don't see any > value in keeping the property about, even deprecated, when it doesn't > work properly. If you insist that it be kept and marked deprecated, it There cannot be an undocumented ABI, so if driver has it, it must stay in the bindings. > needs conditional rules to only permit it on devices that it actually > does something. I'm surprised you even considered that I would drop > support for it from the driver! Commit msg suggested it is no-op, thus could be dropped without having impact? Best regards, Krzysztof