From: Paolo Abeni <pabeni@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
"David S. Miller" <davem@davemloft.net>,
Shuah Khan <shuah@kernel.org>,
linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH net-next 2/3] net/core: introduce default_rps_mask netns attribute
Date: Thu, 29 Oct 2020 18:38:57 +0100 [thread overview]
Message-ID: <8fad8d1ae7554fe4f752f86016a0a0f2eaca8f89.camel@redhat.com> (raw)
In-Reply-To: <20201029081632.2516a39b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Thu, 2020-10-29 at 08:16 -0700, Jakub Kicinski wrote:
> On Wed, 28 Oct 2020 18:46:02 +0100 Paolo Abeni wrote:
> > @@ -46,6 +47,54 @@ int sysctl_devconf_inherit_init_net __read_mostly;
> > EXPORT_SYMBOL(sysctl_devconf_inherit_init_net);
> >
> > #ifdef CONFIG_RPS
> > +struct cpumask rps_default_mask;
>
> net/core/sysctl_net_core.c:50:16: warning: symbol 'rps_default_mask' was not declared. Should it be static?
Thank you for the feedback! I'll address that in v2.
Cheers,
Paolo
next prev parent reply other threads:[~2020-10-29 17:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 17:46 [PATCH net-next 0/3] net: introduce rps_default_mask Paolo Abeni
2020-10-28 17:46 ` [PATCH net-next 1/3] net/sysctl: factor-out netdev_rx_queue_set_rps_mask() helper Paolo Abeni
2020-10-28 17:46 ` [PATCH net-next 2/3] net/core: introduce default_rps_mask netns attribute Paolo Abeni
2020-10-29 15:16 ` Jakub Kicinski
2020-10-29 17:38 ` Paolo Abeni [this message]
2020-10-28 17:46 ` [PATCH net-next 3/3] self-tests: introduce self-tests for RPS default mask Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fad8d1ae7554fe4f752f86016a0a0f2eaca8f89.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).