From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC4A0C352A1 for ; Sun, 4 Dec 2022 03:01:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229774AbiLDDBT (ORCPT ); Sat, 3 Dec 2022 22:01:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229579AbiLDDBS (ORCPT ); Sat, 3 Dec 2022 22:01:18 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A61C18E3E; Sat, 3 Dec 2022 19:01:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=usxMw3MV+5GEjnDpGFKkqnDa17sAb8WuIRuooZDnX6g=; b=ko3wAmfd83ko9fmj5PeckpzbT/ G6k8mLJgXgSR5/yvSCpTKQzUZCiKH4PEswDwgNs88r8Hrxxt/96hj0hfOBNexfKGlXMfkVGo0/a95 FEAaw9w1WxfxGm8Z0b1I0ubVwcZkimk67slxwOjylvQ6oc3RUKJ6otOnHlpv8IYZIFHZ1+RyqQnFv CbbKetCUSAQDXz1N/SYwns8BMgmLYNOZqq6ziwrnoSqL3QtbdlKGzoBQvpmj5rB2JTAtNQ7mVDneE sDYjvbmcv1bhIaZU9tXqL+Z9ZvXmIxyYWsJ4OjSqW8r8LLB9RccQi1WOCIY448WE061AK0Vwix68C RfsVZH2A==; Received: from [2601:1c2:d80:3110::a2e7] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1p1fFc-006EMd-Jb; Sun, 04 Dec 2022 03:01:08 +0000 Message-ID: <8fdd693d-fd25-d16e-b5ce-8aeba83d62f1@infradead.org> Date: Sat, 3 Dec 2022 19:01:07 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH net-next 1/4] net/ethtool: Add netlink interface for the PLCA RS Content-Language: en-US To: Piergiorgio Beruto Cc: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Oleksij Rempel References: <7209a794f6bee74fbfd76178000fd548d95c52ad.1670119328.git.piergiorgio.beruto@gmail.com> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, On 12/3/22 18:49, Piergiorgio Beruto wrote: > Hello Randy, > thank you for your feedback. Although I have worked on the kernel for > quite some time now, I'm pretty new to this process. > > Please, see my answers interleaved. > > On Sat, Dec 03, 2022 at 06:37:13PM -0800, Randy Dunlap wrote: >> Hi-- >> >> On 12/3/22 18:30, Piergiorgio Beruto wrote: >>> Add support for configuring the PLCA Reconciliation Sublayer on >>> multi-drop PHYs that support IEEE802.3cg-2019 Clause 148 (e.g., >>> 10BASE-T1S). This patch adds the appropriate netlink interface >>> to ethtool. >>> >>> Signed-off-by: Piergiorgio Beruto >>> --- >> >> >>> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c >>> index e5b6cb1a77f9..99e3497b6aa1 100644 >>> --- a/drivers/net/phy/phy.c >>> +++ b/drivers/net/phy/phy.c >>> @@ -543,6 +543,40 @@ int phy_ethtool_get_stats(struct phy_device *phydev, >>> } >>> EXPORT_SYMBOL(phy_ethtool_get_stats); >>> >> >> What is the meaning of all these empty kernel-doc comment blocks? >> Why are they here? >> Please delete them. > These functions are placeholders that I've used to have the kernel > compile. The next patch amends those functions and adds the proper > kernel-doc. > > Do you want me to just remove the kernel-doc and leave the functions > TODO? Or would you like me to merge patches 1 and 2? OK, sorry that I missed seeing that. It seems a bit unusual to me -- IMO. I would at least remove the empty kernel-doc comment blocks, but it probably really doesn't matter either way, unless one of the netdev maintainers wants to see it changed. Thanks. > I did this to split the work into smaller, logically isolated and > compiling commits. Please, let me know if I did that wrong. > >>> +/** >>> + * >>> + */ >>> +int phy_ethtool_get_plca_cfg(struct phy_device *dev, >>> + struct phy_plca_cfg *plca_cfg) >>> +{ >>> + // TODO >>> + return 0; >>> +} >>> +EXPORT_SYMBOL(phy_ethtool_get_plca_cfg); >>> + >>> +/** >>> + * >>> + */ >>> +int phy_ethtool_set_plca_cfg(struct phy_device *dev, >>> + struct netlink_ext_ack *extack, >>> + const struct phy_plca_cfg *plca_cfg) >>> +{ >>> + // TODO >>> + return 0; >>> +} >>> +EXPORT_SYMBOL(phy_ethtool_set_plca_cfg); >>> + >>> +/** >>> + * >>> + */ >>> +int phy_ethtool_get_plca_status(struct phy_device *dev, >>> + struct phy_plca_status *plca_st) >>> +{ >>> + // TODO >>> + return 0; >>> +} >>> +EXPORT_SYMBOL(phy_ethtool_get_plca_status); >> >> Thanks. >> -- >> ~Randy > Thank you and kind regards, > Piergiorgio -- ~Randy