From: Oliver Neukum <oneukum@suse.com>
To: Parthiban.Veerasooran@microchip.com
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
piergiorgio.beruto@gmail.com, andrew@lunn.ch,
hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
steve.glendinning@shawell.net, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next 3/3] net: usb: smsc95xx: suspend PHY during USB suspend
Date: Wed, 1 Apr 2026 19:24:17 +0200 [thread overview]
Message-ID: <8fe179bd-417d-4624-9e35-04c75978dfc8@suse.com> (raw)
In-Reply-To: <2e9bc390-c870-46a3-b673-c7cdb5187cc3@microchip.com>
Hi,
On 01.04.26 05:18, Parthiban.Veerasooran@microchip.com wrote:
> Thank you for pointing it out. I agree with you. I didn’t note it
> earlier since the issue did not occur during my testing. I will move the
> phy_suspend() to the appropriate place.
Thank you.
>> And, as a question of principle: Why do you suspend the phy
>> in suspend(), but take no action in resume()?
>
> In resume(), I did not call phy_resume() because the resume path already
> invokes phy_init_hw(), which internally calls
> phydev->drv->config_init(). This reinitializes and reconfigures the PHY.
Thank you for the explanation. May I suggest that you add a comment
to that effect to the driver with your patch? This needs to be pointed
out. Your code as such is fine. It just needs a comment.
Regards
Oliver
next prev parent reply other threads:[~2026-04-01 17:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 13:42 [PATCH net-next 0/3] Add OATC10 Sleep Wake-up support and LAN867x Rev.D0 handling Parthiban Veerasooran
2026-03-30 13:42 ` [PATCH net-next 1/3] net: phy: phy-c45: add OATC10 Sleep/Wakeup support in 10BASE-T1S PHYs Parthiban Veerasooran
2026-03-30 14:46 ` Andrew Lunn
2026-04-01 3:12 ` Parthiban.Veerasooran
2026-03-30 13:42 ` [PATCH net-next 2/3] net: phy: microchip_t1s: add suspend and WOL support for LAN867x Rev.D0 Parthiban Veerasooran
2026-03-30 13:42 ` [PATCH net-next 3/3] net: usb: smsc95xx: suspend PHY during USB suspend Parthiban Veerasooran
2026-03-30 17:39 ` Oliver Neukum
2026-04-01 3:18 ` Parthiban.Veerasooran
2026-04-01 17:24 ` Oliver Neukum [this message]
2026-04-02 5:18 ` Parthiban.Veerasooran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fe179bd-417d-4624-9e35-04c75978dfc8@suse.com \
--to=oneukum@suse.com \
--cc=Parthiban.Veerasooran@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=piergiorgio.beruto@gmail.com \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox