From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org, davem@davemloft.net,
linville@tuxdriver.com, decot@googlers.com
Subject: Reporting transceiver with ethtool_link_ksettings
Date: Tue, 19 Sep 2017 15:03:28 -0700 [thread overview]
Message-ID: <8ff54ee0-0196-075f-207c-81bb8625fb3b@gmail.com> (raw)
Hi,
After tracking down why all network interfaces using PHYLIB and using
phy_ethtool_link_ksettings_get would report "Transceiver: internal" it
became clear that's because ethtool_link_ksettings deprecated that field...
We could have deprecated setting the transceiver which makes sense, but
not deprecating getting the transceiver type which is useful information.
So what are the options here? Would this be acceptable:
diff --git a/ethtool-copy.h b/ethtool-copy.h
index 06fc04c73079..bb9b55806bf4 100644
--- a/ethtool-copy.h
+++ b/ethtool-copy.h
@@ -1752,7 +1752,9 @@ struct ethtool_link_settings {
__u8 eth_tp_mdix;
__u8 eth_tp_mdix_ctrl;
__s8 link_mode_masks_nwords;
- __u32 reserved[8];
+ __u8 transceiver;
+ __u8 reserved1[3];
+ __u32 reserved[7];
__u32 link_mode_masks[0];
/* layout of link_mode_masks fields:
* __u32 map_supported[link_mode_masks_nwords];
reply other threads:[~2017-09-19 22:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ff54ee0-0196-075f-207c-81bb8625fb3b@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=decot@googlers.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox