From: Ed Cashin <ecashin@coraid.com>
To: shemminger@vyatta.com, davem@davemloft.net, ecashin@coraid.com,
harvey.harrison@gmail.com, bzolnier@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH 04/10] AOE: use rcu to find network device
Date: Tue, 10 Nov 2009 15:01:49 -0500 [thread overview]
Message-ID: <8ffe0a1df67d13a45a413f40d00dd80a@coraid.com> (raw)
In-Reply-To: <20091110175647.409162953@vyatta.com>
On Tue Nov 10 13:07:37 EST 2009, shemminger@vyatta.com wrote:
> This gets rid of another use of read_lock(&dev_base_lock) by using
> RCU. Also, it only increments the reference count of the device actually
> used rather than holding and releasing every device
>
> Compile tested only.
This function runs once a minute when the aoe driver is loaded,
if you'd like to test it a bit more.
It looks like there's no dev_put corresponding to the dev_hold
after the changes.
--
Ed
next prev parent reply other threads:[~2009-11-10 20:18 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 17:54 [PATCH 00/10] netdev: get rid of read_lock(&dev_base_lock) usages Stephen Hemminger
2009-11-10 17:54 ` [PATCH 01/10] netdev: add netdev_continue_rcu Stephen Hemminger
2009-11-10 18:19 ` Eric Dumazet
2009-11-11 6:47 ` David Miller
2009-11-10 19:39 ` Paul E. McKenney
2009-11-10 17:54 ` [PATCH 02/10] vlan: eliminate use of dev_base_lock Stephen Hemminger
2009-11-10 18:20 ` Eric Dumazet
2009-11-11 6:47 ` David Miller
2009-11-10 17:54 ` [PATCH 03/10] net: use rcu for network scheduler API Stephen Hemminger
2009-11-10 18:20 ` Eric Dumazet
2009-11-11 6:47 ` David Miller
2009-11-10 17:54 ` [PATCH 04/10] AOE: use rcu to find network device Stephen Hemminger
2009-11-10 18:23 ` Eric Dumazet
2009-11-10 20:01 ` Ed Cashin [this message]
2009-11-10 23:06 ` Stephen Hemminger
2009-11-10 23:53 ` Stephen Hemminger
2009-11-11 6:48 ` David Miller
2009-11-12 14:33 ` Ed Cashin
2009-11-12 17:10 ` Stephen Hemminger
2009-11-12 18:07 ` Ed Cashin
2009-11-12 19:09 ` Stephen Hemminger
2009-11-18 16:49 ` Ed Cashin
2009-11-11 14:22 ` Ed Cashin
2009-11-13 21:39 ` Ed Cashin
2009-11-13 22:24 ` Stephen Hemminger
2009-11-10 17:54 ` [PATCH 05/10] parisc: use RCU " Stephen Hemminger
2009-11-10 18:26 ` Eric Dumazet
2009-11-11 6:48 ` David Miller
2009-11-10 17:54 ` [PATCH 06/10] s390: use RCU to walk list of network devices Stephen Hemminger
2009-11-10 18:27 ` Eric Dumazet
2009-11-10 18:29 ` Stephen Hemminger
2009-11-10 18:40 ` Eric Dumazet
2009-11-11 6:49 ` David Miller
2009-11-10 17:54 ` [PATCH 07/10] decnet: use RCU to find " Stephen Hemminger
2009-11-10 18:43 ` Eric Dumazet
2009-11-10 18:50 ` Stephen Hemminger
2009-11-10 18:24 ` steve
2009-11-11 17:39 ` [PATCH 1/2] decnet: add RTNL lock when reading address list Stephen Hemminger
2009-11-11 17:40 ` [PATCH 2/2] decnet: convert dndev_lock to spinlock Stephen Hemminger
2009-11-12 3:56 ` David Miller
2009-11-12 3:56 ` [PATCH 1/2] decnet: add RTNL lock when reading address list David Miller
2009-11-10 19:25 ` [PATCH 07/10] decnet: use RCU to find network devices Eric Dumazet
2009-11-11 6:49 ` David Miller
2009-11-10 17:54 ` [PATCH 08/10] ipv6: use RCU to walk list of " Stephen Hemminger
2009-11-11 6:50 ` David Miller
2009-11-12 3:34 ` [PATCH net-next-2.6] " Eric Dumazet
2009-11-14 4:39 ` David Miller
2009-11-10 17:54 ` [PATCH 09/10] IPV4: use rcu to walk list of devices in IGMP Stephen Hemminger
2009-11-10 18:47 ` Eric Dumazet
2009-11-11 6:50 ` David Miller
2009-11-10 17:54 ` [PATCH 10/10] CAN: use dev_get_by_index_rcu Stephen Hemminger
2009-11-10 18:34 ` Eric Dumazet
2009-11-11 5:54 ` Oliver Hartkopp
2009-11-11 6:50 ` David Miller
2009-11-10 18:18 ` [PATCH 00/10] netdev: get rid of read_lock(&dev_base_lock) usages Eric Dumazet
2009-11-10 18:22 ` Stephen Hemminger
2009-11-10 18:24 ` Stephen Hemminger
2009-11-10 18:39 ` Eric Dumazet
2009-11-10 18:53 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ffe0a1df67d13a45a413f40d00dd80a@coraid.com \
--to=ecashin@coraid.com \
--cc=bzolnier@gmail.com \
--cc=davem@davemloft.net \
--cc=harvey.harrison@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).