[PATCH]-bonding: Fix slave link failure count update failure

[PATCH]-bonding: Fix slave link failure count update failure

[Narendra_K]

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]


Hello,

The "bonding: refactor mii monitor" patch (
http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.27.y.git;a=co
mmit;h=f0c76d61779b153dbfb955db3f144c62d02173c2) misses updating the
slave link failure count. So "cat /proc/net/bonding/bond0" doesn't
reflect the no of slave link failures. The patch addresses it.

Signed-off-by: Narendra K <narendra_k@dell.com>

With regards,
Narendra K

[-- Attachment #2: bond_slave_link_failure_count.patch --]
[-- Type: application/octet-stream, Size: 471 bytes --]

--- linux-2.6.27.9/drivers/net/bonding/bond_main.c	2008-12-14 05:26:16.000000000 +0530
+++ linux-2.6.27.9-new/drivers/net/bonding/bond_main.c	2008-12-15 19:06:48.000000000 +0530
@@ -2241,6 +2241,11 @@
 
 			slave->link = BOND_LINK_FAIL;
 			slave->delay = bond->params.downdelay;
+
+			if (slave->link_failure_count < UINT_MAX) {
+				slave->link_failure_count++;
+			}
+
 			if (slave->delay) {
 				printk(KERN_INFO DRV_NAME
 				       ": %s: link status down for %s"

Re: [PATCH]-bonding: Fix slave link failure count update failure

[Jay Vosburgh]

<Narendra_K@Dell.com> wrote:
[...]
>The "bonding: refactor mii monitor" patch (
>http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.27.y.git;a=co
>mmit;h=f0c76d61779b153dbfb955db3f144c62d02173c2) misses updating the
>slave link failure count. So "cat /proc/net/bonding/bond0" doesn't
>reflect the no of slave link failures. The patch addresses it.

	This is already fixed in mainline by:

commit fba4acda35f3119328bcba28aacefae14245d2bb
Author: Jay Vosburgh <fubar@us.ibm.com>
Date:   Thu Oct 30 17:41:14 2008 -0700

    bonding: fix miimon failure counter

	Note that the two patches add the increment to different places,
so applying both of them will result in double increments.

	-J

---
	-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com