From: Thinh Tran <thinhtr@linux.vnet.ibm.com>
To: kuba@kernel.org
Cc: netdev@vger.kernel.org, aelior@marvell.com, davem@davemloft.net,
manishc@marvell.com, pabeni@redhat.com, skalluru@marvell.com,
simon.horman@corigine.com, edumazet@google.com,
VENKATA.SAI.DUGGI@ibm.com, drc@linux.vnet.ibm.com,
abdhalee@in.ibm.com, thinhtr@linux.vnet.ibm.com
Subject: [PATCH v7 1/2] net/bnx2x: Prevent access to a freed page in page_pool
Date: Thu, 1 Feb 2024 11:48:21 -0600 [thread overview]
Message-ID: <90238577e00a7a996767b84769b5e03ef840b13a.1706804455.git.thinhtr@linux.vnet.ibm.com> (raw)
In-Reply-To: <cover.1706804455.git.thinhtr@linux.vnet.ibm.com>
Verify page pool allocations before freeing.
Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h
index d8b1824c334d..0bc1367fd649 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h
@@ -1002,9 +1002,6 @@ static inline void bnx2x_set_fw_mac_addr(__le16 *fw_hi, __le16 *fw_mid,
static inline void bnx2x_free_rx_mem_pool(struct bnx2x *bp,
struct bnx2x_alloc_pool *pool)
{
- if (!pool->page)
- return;
-
put_page(pool->page);
pool->page = NULL;
@@ -1015,6 +1012,9 @@ static inline void bnx2x_free_rx_sge_range(struct bnx2x *bp,
{
int i;
+ if (!fp->page_pool.page)
+ return;
+
if (fp->mode == TPA_MODE_DISABLED)
return;
--
2.25.1
next prev parent reply other threads:[~2024-02-01 17:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 17:48 [PATCH v7 0/2] bnx2x: Fix error recovering in switch configuration Thinh Tran
2024-02-01 17:48 ` Thinh Tran [this message]
2024-02-08 2:37 ` [PATCH v7 1/2] net/bnx2x: Prevent access to a freed page in page_pool Jakub Kicinski
2024-02-01 17:48 ` [PATCH v7 2/2] net/bnx2x: refactor common code to bnx2x_stop_nic() Thinh Tran
2024-02-08 18:55 ` [PATCH v8 0/2] bnx2x: Fix error recovering in switch configuration Thinh Tran
2024-02-08 18:55 ` [PATCH v8 1/2] net/bnx2x: Prevent access to a freed page in page_pool Thinh Tran
2024-02-08 19:14 ` Thinh Tran
2024-02-08 19:18 ` Thinh Tran
2024-02-09 1:29 ` Jakub Kicinski
2024-02-12 20:47 ` Thinh Tran
2024-02-12 20:47 ` [PATCH v9 " Thinh Tran
2024-02-08 18:55 ` [PATCH v8 2/2] net/bnx2x: refactor common code to bnx2x_stop_nic() Thinh Tran
2024-02-12 20:47 ` [PATCH v9 " Thinh Tran
2024-02-12 20:47 ` [PATCH v9 0/2] bnx2x: Fix error recovering in switch configuration Thinh Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90238577e00a7a996767b84769b5e03ef840b13a.1706804455.git.thinhtr@linux.vnet.ibm.com \
--to=thinhtr@linux.vnet.ibm.com \
--cc=VENKATA.SAI.DUGGI@ibm.com \
--cc=abdhalee@in.ibm.com \
--cc=aelior@marvell.com \
--cc=davem@davemloft.net \
--cc=drc@linux.vnet.ibm.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=skalluru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).