From: Jay Vosburgh <jay.vosburgh@canonical.com>
To: Mahesh Bandewar <maheshb@google.com>
Cc: Andy Gospodarek <andy@greyhouse.net>,
Veaceslav Falico <vfalico@gmail.com>,
Nikolay Aleksandrov <nikolay@redhat.com>,
David Miller <davem@davemloft.net>,
Maciej Zenczykowski <maze@google.com>,
netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH next v5 4/6] bonding: Allow userspace to set actors' system_priority in AD system
Date: Thu, 19 Feb 2015 13:06:29 -0800 [thread overview]
Message-ID: <9036.1424379989@famine> (raw)
In-Reply-To: <1424298685-18394-1-git-send-email-maheshb@google.com>
Mahesh Bandewar <maheshb@google.com> wrote:
>This patch allows user to randomize the system-priority in an ad-system.
>The allowed range is 1 - 0xFFFF while default value is 0xFFFF. If user
>does not specify this value, the system defaults to 0xFFFF, which is
>what it was before this patch.
>
>Following example code could set the value -
> # modprobe bonding mode=4
> # sys_prio=$(( 1 + RANDOM + RANDOM ))
> # echo $sys_prio > /sys/class/net/bond0/bonding/ad_actor_sys_prio
> # echo +eth1 > /sys/class/net/bond0/bonding/slaves
> ...
> # ip link set bond0 up
>
>Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Mahesh: Andy and I got together at netdev01 and discussed the
patches of this series that add options to sysfs for bonding (patches 4,
5 and 6). In summary, in my opinion a netlink / iproute2 interface
needs to be provided simultaneously with any new sysfs interface for
bonding. I realize that the sysfs api to bonding won't go away, but
nevertheless users should be encouraged to use netlink preferentially.
Providing the api pieces together encourages this.
As it happens, Andy mentioned that he has patches similar to
these three, but with the netlink portion already implemented.
My suggestion here is therefore for Andy to post his patches,
and then we can merge these together, and get this implemented properly
with a minimum of duplicated effort.
-J
---
-Jay Vosburgh, jay.vosburgh@canonical.com
prev parent reply other threads:[~2015-02-19 21:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 22:31 [PATCH next v5 4/6] bonding: Allow userspace to set actors' system_priority in AD system Mahesh Bandewar
2015-02-19 0:13 ` Nikolay Aleksandrov
2015-02-19 21:06 ` Jay Vosburgh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9036.1424379989@famine \
--to=jay.vosburgh@canonical.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=maheshb@google.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).