From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40924C433E7 for ; Thu, 8 Oct 2020 21:52:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DEAF022242 for ; Thu, 8 Oct 2020 21:51:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729473AbgJHVv7 (ORCPT ); Thu, 8 Oct 2020 17:51:59 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:33566 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726293AbgJHVv6 (ORCPT ); Thu, 8 Oct 2020 17:51:58 -0400 Received: by mail-wr1-f67.google.com with SMTP id m6so8187454wrn.0 for ; Thu, 08 Oct 2020 14:51:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iJXlEB+Px1Bh29uSjjaKgu7whRXUx1wvZLQkXigqHdE=; b=Tzon2cCb+2N//mm6sqfJAx+D9VdeZf3E4CMTkstAAUkX6pdz6eEXBibbrUBo2oYo+v Z/IMseitcIk1SOz59EQW5PM1ewvUX7pI3bjIRq3i4h+ywJ+dY5vk0PxWzJaAsb+GJeRa LwBb6qw+eI9Fxw9pB67UBVSIWXzkXOJmIY3qgoV69h7tGd7l61Q0NUbFXoKIRVxwK2oJ DsexsTsmYOyzj3Qj46kQKkpTFCoOfLdNBKFT2lgTaaxJ/09bYsg6/rLuWVRuzT2job4j hljVTqIwIEzE/DUJckJyi8FtvoliyUSmc3PgeHC/2fVdaPM/Ozjq+Hyz/o18+2QMB04H efFw== X-Gm-Message-State: AOAM530ynhhVfHJqQwvBALQWFZrzQDv+6oaltib5HBj8ehN3c5uUffzD UQ5rmZbUBGZbkuhtAcL5jPs= X-Google-Smtp-Source: ABdhPJwJ7oTNHeMtK2UwxXqxI2a25TbVKjna+8whwhBksIwUGhMPofkX7Eg64tfJMI/ghTWDj9AlZg== X-Received: by 2002:adf:d84e:: with SMTP id k14mr11803304wrl.251.1602193916816; Thu, 08 Oct 2020 14:51:56 -0700 (PDT) Received: from ?IPv6:2601:647:4802:9070:68d6:3fd5:5a8b:9959? ([2601:647:4802:9070:68d6:3fd5:5a8b:9959]) by smtp.gmail.com with ESMTPSA id z6sm3872809wrs.2.2020.10.08.14.51.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Oct 2020 14:51:56 -0700 (PDT) Subject: Re: [PATCH net-next RFC v1 03/10] net: Introduce crc offload for tcp ddp ulp To: Boris Pismenny , kuba@kernel.org, davem@davemloft.net, saeedm@nvidia.com, hch@lst.de, axboe@fb.com, kbusch@kernel.org, viro@zeniv.linux.org.uk, edumazet@google.com Cc: Yoray Zack , Ben Ben-Ishay , boris.pismenny@gmail.com, linux-nvme@lists.infradead.org, netdev@vger.kernel.org, Or Gerlitz References: <20200930162010.21610-1-borisp@mellanox.com> <20200930162010.21610-4-borisp@mellanox.com> From: Sagi Grimberg Message-ID: <904a5edf-3f50-5f6f-6bc6-3d1a1a664aa5@grimberg.me> Date: Thu, 8 Oct 2020 14:51:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200930162010.21610-4-borisp@mellanox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > This commit itroduces support for CRC offload to direct data placement introduces > ULP on the receive side. Both DDP and CRC share a common API to > initialize the offload for a TCP socket. But otherwise, both can > be executed independently. From the API it not clear that the offload engine does crc32c, do you see this extended to other crc types in the future? Other than this the patch looks good to me, Reviewed-by: Sagi Grimberg