From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 829A517A314 for ; Sat, 22 Aug 2026 22:19:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787437184; cv=none; b=F7fW/ybYilomfh3hDxtroDaE00FJxN2BDe8EanPafYo6wO/GyEY+p2nVSDYY/MRw53FvK2J9QdUKboPSHfgd+0eJLJzXWtjXW24I122Je7N2pycj4vVBkZ6QfDofSNtW86aUEVD/5lzWK69knORetRLizXvb0sd9hOXu4a2v7bk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787437184; c=relaxed/simple; bh=2IFIrXXQx/YTLSk7qgjW+/GYCEMiGGrTEdWZJHI1F3M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PDf4AazOGK2ZtDcdJhMosvNVj4X8ZfdfT3BgHOCErwI1tcrwxnBj0f5I/Ld1LjYXyoHu+JlMB/CchZAz0YLWThNrC5wCFg2VJIQtal4AedRdIfVKTRvf0mVLWRm9B670+LFR2JxsH2o1XfOEm1euf6fTZ9oDISWXvjVqE1MaHd4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=grimberg.me; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=grimberg.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-6a17cb94b26so4446542a12.3 for ; Sat, 22 Aug 2026 15:19:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787437181; x=1788041981; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HeO8qz7gI/PQdjAfS1WIWNrGC+sH7zaBOZAEPxSZsz0=; b=ZUUEVwKxdYaEv3EJwkucdGlwlJTnxQn1PFBZX3Jd6e9uN8NbfNnkRrejiV39Ktl2dO EH10vLV/hUlpgsoDvhNy4xbO6LUB6Wnxehc85Fzpk9o5IFcgV19l44hgDZIX90CpQXd2 HHah9/3plr3//8XZtJCNEDTFL0ynMX79a6m2rnr6sELrLZnnVe2y3AGrweqMRmja6qBp ih6D2YavFLvG8Lgr+RfsPxRqBD9OgUmZlLoWDwvTEfdiTIoLC3jwGEYYUkAFrCdp/cmX h8bGtb3+/foZt3BeZ4iDjyfmPef1T45lPruLi9vwIBYyfJ0NzMpQb/RHF90u2m8mL03/ G/qA== X-Forwarded-Encrypted: i=1; AHgh+Rp9ewrreH5/gkD3KAFUXmyXeAGE4XNPXbrdGJ6TmzCZ0uCDNq8WiyL2LifmuWuH59Ufyt11BjY=@vger.kernel.org X-Gm-Message-State: AFuF++n097n9RTg8hldpMhJJBtYXVrZ0BV3kMQqJtBy3BqXfonSW7KPo hB/h9Br/Cw1BpY1adt1qm2cKWrQfF3aKfv746YUHw+BlVlx9WvklN2GA X-Gm-Gg: AR+sD117GZ5xt/Ytcayvvf32BQbcOSVLtBZy8WYojqC3mUoLGKCqzu6iCnvda5xqKqG AmBSovFIO/pmd4XkbYAhC8SsY5l2Nf/Q5FaJNjyoWvYTAkaq91HwK3ZndjFBB6Fg6KaZeVWaCuZ XGiCUy9TH0lFd/U+BkPsC/QU+ESY7fJYD7NjKjWBfL2wk/l5nj7GspPJCBlB74ELPGFqE59nHLw Siy7mpnadXkbDUFcnNRIIxM/gxWM2qh1mzjvAYLvI1R65VcX9WJ0NE1sX2z67tF+Gm3dmWoYsl7 /CMSoCw8V/rjtBmnsSI+fD8YKvdfVVB3bsWeazPwjdxzg4/91pqhIQJQcmyEkhXdZTDscXHpq3I shdaF7oHbFmsYvGwim4t4LXzQLkYECClcmbPKcGZcsdc73LLo0r8ciKStsa9EMSt0TsUpI0LvhE KBi3b1J1H8kWPhB0luzqpI2CeeM4PIdzO/0M0Dcpa1joIDdf9ssuF0z2mocTNxJdW2BRfiPRNMi 4W8V8d1AkxC3OcYmiggWgg= X-Received: by 2002:a17:906:fe49:b0:c24:b11c:6bf9 with SMTP id a640c23a62f3a-c24b11c6d84mr220160966b.6.1787437180599; Sat, 22 Aug 2026 15:19:40 -0700 (PDT) Received: from [10.100.102.74] (89-138-65-240.bb.netvision.net.il. [89.138.65.240]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c24967383e5sm483628966b.45.2026.08.22.15.19.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Aug 2026 15:19:40 -0700 (PDT) Message-ID: <904ec61e-17e1-42f6-8215-63a806aeca76@grimberg.me> Date: Sun, 23 Aug 2026 01:19:38 +0300 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/4] nvme-tcp: support IPv6 traffic class To: Geliang Tang , Keith Busch , Jens Axboe , Christoph Hellwig , Chaitanya Kulkarni , David Ahern , Ido Schimmel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Hannes Reinecke , Stanislav Fomichev Cc: Geliang Tang , linux-nvme@lists.infradead.org, netdev@vger.kernel.org, mptcp@lists.linux.dev References: Content-Language: en-US From: Sagi Grimberg In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18/08/2026 9:03, Geliang Tang wrote: > From: Geliang Tang > > Currently, nvme-tcp host only supports setting the IPv4 TOS value when a > TOS is specified, but does not handle the IPv6 traffic class. > > Extend the queue socket setup to handle AF_INET6 sockets by applying the > TOS value to both IPv4 and IPv6 sockets. For IPv6, the TOS value is set > as the IPv6 traffic class via IPV6_TCLASS using do_sock_setsockopt(). > > Signed-off-by: Geliang Tang > --- > drivers/nvme/host/tcp.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c > index 025cade370b2..5f30be04a9dd 100644 > --- a/drivers/nvme/host/tcp.c > +++ b/drivers/nvme/host/tcp.c > @@ -1815,6 +1815,17 @@ static int nvme_tcp_sock_set_tos(struct sock *sk, int tos) > KERNEL_SOCKPTR(&tos), sizeof(tos)); > } > > +static int nvme_tcp_sock_set_tclass(struct sock *sk, int tclass) > +{ > +#if IS_ENABLED(CONFIG_IPV6) > + if (sk->sk_family == AF_INET6) > + return do_sock_setsockopt(sk->sk_socket, false, SOL_IPV6, > + IPV6_TCLASS, KERNEL_SOCKPTR(&tclass), > + sizeof(tclass)); > +#endif > + return 0; > +} > + > static int nvme_tcp_alloc_queue(struct nvme_ctrl *nctrl, int qid, > key_serial_t pskid) > { > @@ -1909,6 +1920,15 @@ static int nvme_tcp_alloc_queue(struct nvme_ctrl *nctrl, int qid, > qid, ret); > goto err_sock; > } > + > + ret = nvme_tcp_sock_set_tclass(queue->sock->sk, > + nctrl->opts->tos); Won't it just be cleaner to add a generic ip_sock_set_tclass() that hides the IS_ENABLED(CONFIG_IPV6) ifdef? Why do we need to wrap all these generic helpers?