From: Claudiu Beznea <claudiu.beznea@tuxon.dev>
To: Nicolai Buchwitz <nb@tipi-net.de>, netdev@vger.kernel.org
Cc: davem@davemloft.net, andrew+netdev@lunn.ch, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, linux@armlinux.org.uk,
nicolas.ferre@microchip.com, linux-kernel@vger.kernel.org,
theo.lebrun@bootlin.com, phil@raspberrypi.com
Subject: Re: [PATCH net-next v5 3/5] net: cadence: macb: add ethtool EEE support
Date: Sat, 28 Feb 2026 15:32:01 +0200 [thread overview]
Message-ID: <905b0bd8-dce4-4921-b7f2-4d694a02533f@tuxon.dev> (raw)
In-Reply-To: <20260227150610.242215-4-nb@tipi-net.de>
On 2/27/26 17:06, Nicolai Buchwitz wrote:
> Implement get_eee and set_eee ethtool ops for GEM as simple passthroughs
> to phylink_ethtool_get_eee() and phylink_ethtool_set_eee().
>
> No MACB_CAPS_EEE guard is needed: phylink returns -EOPNOTSUPP from both
> ops when mac_supports_eee is false, which is the case when
> lpi_capabilities and lpi_interfaces are not populated. Those fields are
> only set when MACB_CAPS_EEE is present (previous patch), so phylink
> already handles the unsupported case correctly.
>
> Reviewed-by: Théo Lebrun<theo.lebrun@bootlin.com>
> Signed-off-by: Nicolai Buchwitz<nb@tipi-net.de>
Reviewed-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
next prev parent reply other threads:[~2026-02-28 13:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 15:06 [PATCH net-next v5 0/5] net: cadence: macb: add IEEE 802.3az EEE support Nicolai Buchwitz
2026-02-27 15:06 ` [PATCH net-next v5 1/5] net: cadence: macb: add EEE LPI statistics counters Nicolai Buchwitz
2026-02-28 13:33 ` Claudiu Beznea
2026-02-27 15:06 ` [PATCH net-next v5 2/5] net: cadence: macb: implement EEE TX LPI support Nicolai Buchwitz
2026-02-28 13:34 ` Claudiu Beznea
2026-03-03 2:15 ` Jakub Kicinski
2026-03-03 8:14 ` Théo Lebrun
2026-03-03 16:53 ` Jakub Kicinski
2026-02-27 15:06 ` [PATCH net-next v5 3/5] net: cadence: macb: add ethtool EEE support Nicolai Buchwitz
2026-02-28 13:32 ` Claudiu Beznea [this message]
2026-02-27 15:06 ` [PATCH net-next v5 4/5] net: cadence: macb: enable EEE for Raspberry Pi RP1 Nicolai Buchwitz
2026-02-28 13:31 ` Claudiu Beznea
2026-02-27 15:06 ` [PATCH net-next v5 5/5] net: cadence: macb: enable EEE for Mobileye EyeQ5 Nicolai Buchwitz
2026-02-28 13:31 ` Claudiu Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=905b0bd8-dce4-4921-b7f2-4d694a02533f@tuxon.dev \
--to=claudiu.beznea@tuxon.dev \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=phil@raspberrypi.com \
--cc=theo.lebrun@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox