From: Romain Perier <romain.perier@collabora.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: stmmac: Use the right logging function in stmmac_mdio_register
Date: Wed, 9 Aug 2017 16:58:24 +0200 [thread overview]
Message-ID: <9067382c-412f-343e-8273-4464366ba0f2@collabora.com> (raw)
In-Reply-To: <20170809145651.GK30723@lunn.ch>
Hi Andrew,
Le 09/08/2017 à 16:56, Andrew Lunn a écrit :
> On Wed, Aug 09, 2017 at 04:40:19PM +0200, Romain Perier wrote:
>> @@ -285,14 +286,14 @@ int stmmac_mdio_register(struct net_device *ndev)
>> irq_str = irq_num;
>> break;
>> }
>> - netdev_info(ndev, "PHY ID %08x at %d IRQ %s (%s)%s\n",
>> + dev_info(dev, "PHY ID %08x at %d IRQ %s (%s)%s\n",
>> phydev->phy_id, addr, irq_str, phydev_name(phydev),
>> act ? " active" : "");
> Hi Romain
>
> phy_attached_print() would be better.
>
> Andrew
Ok, I did not know this function, good to know. I will investigate
Thanks,
Romain
prev parent reply other threads:[~2017-08-09 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 14:40 [PATCH] net: stmmac: Use the right logging function in stmmac_mdio_register Romain Perier
2017-08-09 14:56 ` Andrew Lunn
2017-08-09 14:58 ` Romain Perier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9067382c-412f-343e-8273-4464366ba0f2@collabora.com \
--to=romain.perier@collabora.com \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).