[PATCH 1/1] idpf: Clean up the vmvf_type for ctlq_recv functions

[PATCH 1/1] idpf: Clean up the vmvf_type for ctlq_recv functions

[Zhu Yanjun]

From: Zhu Yanjun <yanjun.zhu@linux.dev>

In the original source code, add vmvf_type to ctrl_msg for ctlq_recv
functions. These new types will be implemented and used. But currently
these types are not used. So remove them.

Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
---
 drivers/net/ethernet/intel/idpf/idpf_controlq_api.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/intel/idpf/idpf_controlq_api.h b/drivers/net/ethernet/intel/idpf/idpf_controlq_api.h
index 8dee098bbfb0..e1b6ee87ad95 100644
--- a/drivers/net/ethernet/intel/idpf/idpf_controlq_api.h
+++ b/drivers/net/ethernet/intel/idpf/idpf_controlq_api.h
@@ -37,9 +37,6 @@ struct idpf_ctlq_reg {
 /* Generic queue msg structure */
 struct idpf_ctlq_msg {
 	u8 vmvf_type; /* represents the source of the message on recv */
-#define IDPF_VMVF_TYPE_VF 0
-#define IDPF_VMVF_TYPE_VM 1
-#define IDPF_VMVF_TYPE_PF 2
 	u8 host_id;
 	/* 3b field used only when sending a message to CP - to be used in
 	 * combination with target func_id to route the message
-- 
2.39.2

Re: [Intel-wired-lan] [PATCH 1/1] idpf: Clean up the vmvf_type for ctlq_recv functions

[Przemek Kitszel]

On 3/12/24 07:15, Zhu Yanjun wrote:
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
> 
> In the original source code, add vmvf_type to ctrl_msg for ctlq_recv
> functions. These new types will be implemented and used. But currently
> these types are not used. So remove them.

This commit message is hard to read.
Also please try to use imperative mood, and avoid phrases like "this 
commit", "in the code", as most likely those are implicit.

Please also wait with your contribution for next window opening.

For Intel Employees this internal wiki could be useful:
https://wiki.ith.intel.com/display/LADSW/Common+faults+when+sending+%28a+first%29+series+upstream

> 
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> ---
>   drivers/net/ethernet/intel/idpf/idpf_controlq_api.h | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_controlq_api.h b/drivers/net/ethernet/intel/idpf/idpf_controlq_api.h
> index 8dee098bbfb0..e1b6ee87ad95 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_controlq_api.h
> +++ b/drivers/net/ethernet/intel/idpf/idpf_controlq_api.h
> @@ -37,9 +37,6 @@ struct idpf_ctlq_reg {
>   /* Generic queue msg structure */
>   struct idpf_ctlq_msg {
>   	u8 vmvf_type; /* represents the source of the message on recv */
> -#define IDPF_VMVF_TYPE_VF 0
> -#define IDPF_VMVF_TYPE_VM 1
> -#define IDPF_VMVF_TYPE_PF 2
>   	u8 host_id;
>   	/* 3b field used only when sending a message to CP - to be used in
>   	 * combination with target func_id to route the message