From: Tom St Denis <tstdenis@elliptictech.com>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org, David Miller <davem@davemloft.net>,
Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Subject: Re: [PATCH] CMAC support for CryptoAPI, fixed patch issues, indent, and testmgr build issues
Date: Thu, 24 Jan 2013 07:37:50 -0500 (EST) [thread overview]
Message-ID: <909599053.113808.1359031070783.JavaMail.root@elliptictech.com> (raw)
In-Reply-To: <20130124123210.GK9147@secunet.com>
----- Original Message -----
> From: "Steffen Klassert" <steffen.klassert@secunet.com>
> To: "Jussi Kivilinna" <jussi.kivilinna@mbnet.fi>
> Cc: "Herbert Xu" <herbert@gondor.apana.org.au>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
> linux-crypto@vger.kernel.org, "Tom St Denis" <tstdenis@elliptictech.com>, "David Miller" <davem@davemloft.net>
> Sent: Thursday, 24 January, 2013 7:32:10 AM
> Subject: Re: [PATCH] CMAC support for CryptoAPI, fixed patch issues, indent, and testmgr build issues
>
> On Thu, Jan 24, 2013 at 01:25:46PM +0200, Jussi Kivilinna wrote:
> >
> > Maybe it would be cleaner to not mess with pfkeyv2.h at all, but
> > instead mark algorithms that do not support pfkey with flag. See
> > patch below.
> >
>
> Yes, would be an option too. I would be fine with that,
> but let's here if someone else has an opinion on this.
> Anyway, we need a solution to integrate Tom's patch soon.
Has anyone addressed the testmgr issues too? I wasn't able to run the self-tests so I don't even know if the vectors were copied correctly.
Also a question for the netdev folk, in order to be timely would it be acceptable to patch ah4 and then ah6 with the AEAD changes? Or would the team require both to be patched simultaneously?
Tom
next prev parent reply other threads:[~2013-01-24 12:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <537355069.94465.1358772395763.JavaMail.root@elliptictech.com>
[not found] ` <436404741.94502.1358773048618.JavaMail.root@elliptictech.com>
2013-01-21 16:40 ` [PATCH] CMAC support for CryptoAPI, fixed patch issues, indent, and testmgr build issues David Dillow
2013-01-23 7:41 ` Steffen Klassert
2013-01-23 14:36 ` Jussi Kivilinna
2013-01-23 14:46 ` Tom St Denis
2013-01-23 15:35 ` Jussi Kivilinna
2013-01-23 15:46 ` Tom St Denis
2013-01-23 16:16 ` YOSHIFUJI Hideaki
2013-01-23 16:25 ` YOSHIFUJI Hideaki
2013-01-24 8:45 ` Jussi Kivilinna
2013-01-24 9:43 ` Steffen Klassert
2013-01-24 11:25 ` Jussi Kivilinna
2013-01-24 12:32 ` Steffen Klassert
2013-01-24 12:37 ` Tom St Denis [this message]
2013-01-24 12:52 ` Steffen Klassert
2013-01-24 13:00 ` Tom St Denis
2013-01-29 9:33 ` Steffen Klassert
2013-01-31 9:35 ` Jussi Kivilinna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=909599053.113808.1359031070783.JavaMail.root@elliptictech.com \
--to=tstdenis@elliptictech.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jussi.kivilinna@mbnet.fi \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).