From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Jungel Subject: [PATCH] bonding: fix length of actor system Date: Sat, 27 Oct 2018 15:31:46 +0200 Message-ID: <909d24e39a29f9b5a7e7df171ebaa60e822bd90c.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Eric Dumazet , netdev@vger.kernel.org To: Jay Vosburgh , Veaceslav Falico , Andy Gospodarek Return-path: Received: from mail-wr1-f67.google.com ([209.85.221.67]:43489 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728017AbeJ0WMv (ORCPT ); Sat, 27 Oct 2018 18:12:51 -0400 Received: by mail-wr1-f67.google.com with SMTP id t10-v6so3964371wrn.10 for ; Sat, 27 Oct 2018 06:31:49 -0700 (PDT) Sender: netdev-owner@vger.kernel.org List-ID: The attribute IFLA_BOND_AD_ACTOR_SYSTEM is sent to user space having the length of sizeof(bond->params.ad_actor_system) which is 8 byte. This patch aligns the length to ETH_ALEN to have the same MAC address exposed as using sysfs. fixes f87fda00b6ed2 Signed-off-by: Tobias Jungel --- drivers/net/bonding/bond_netlink.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c index 9697977b80f0..6b9ad8673218 100644 --- a/drivers/net/bonding/bond_netlink.c +++ b/drivers/net/bonding/bond_netlink.c @@ -638,8 +638,7 @@ static int bond_fill_info(struct sk_buff *skb, goto nla_put_failure; if (nla_put(skb, IFLA_BOND_AD_ACTOR_SYSTEM, - sizeof(bond->params.ad_actor_system), - &bond->params.ad_actor_system)) + ETH_ALEN, &bond->params.ad_actor_system)) goto nla_put_failure; } if (!bond_3ad_get_active_agg_info(bond, &info)) {