From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:60488 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751279AbeCOAfI (ORCPT ); Wed, 14 Mar 2018 20:35:08 -0400 From: Song Liu To: Daniel Borkmann CC: "netdev@vger.kernel.org" , "ast@kernel.org" , "peterz@infradead.org" , Kernel Team , "hannes@cmpxchg.org" , Teng Qin Subject: Re: [PATCH bpf-next v6 0/2] bpf stackmap with build_id+offset Date: Thu, 15 Mar 2018 00:34:20 +0000 Message-ID: <90BD628F-C268-42C3-B3B4-A7548CEADDBA@fb.com> References: <20180314172323.3957483-1-songliubraving@fb.com> <46bec038-f793-7ce6-686f-adee7f462dec@iogearbox.net> In-Reply-To: <46bec038-f793-7ce6-686f-adee7f462dec@iogearbox.net> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org List-ID: > On Mar 14, 2018, at 5:29 PM, Daniel Borkmann wrote= : >=20 > On 03/14/2018 06:23 PM, Song Liu wrote: >> Changes v4 -> v6: >>=20 >> 1. When kernel stack is added to stackmap with build_id, use fallback >> mechanism to store ip (status =3D=3D BPF_STACK_BUILD_ID_IP). >>=20 >> Changes v4 -> v5: >>=20 >> 1. Only allow build_id lookup in non-nmi context. Added comment and >> commit message to highlight this limitation. >> 2. Minor fix reported by kbuild test robot. >>=20 >> Changes v3 -> v4: >>=20 >> 1. Add fallback when build_id lookup failed. In this case, status is set >> to BPF_STACK_BUILD_ID_IP, and ip of this entry is saved. >> 2. Handle cases where vma is only part of the file (vma->vm_pgoff !=3D 0= ). >> Thanks to Teng for helping me identify this issue! >> 3. Address feedbacks for previous versions. >=20 > Applied to bpf-next, thanks Song! >=20 > P.s.: In the merge commit I included your description from the original > v1 cover letter to provide readers with some more context. Please don't > remove such things in future from cover letter. Only the above doesn't > really say much about the series overall. Get it! Thanks Daniel! Best, Song