netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@kernel.org>
To: Gal Pressman <gal@nvidia.com>,
	Richard Gobert <richardbgobert@gmail.com>,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, aleksander.lobakin@intel.com,
	lixiaoyan@google.com, lucien.xin@gmail.com,
	alexanderduyck@fb.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] gro: decrease size of CB
Date: Wed, 23 Aug 2023 20:31:21 -0700	[thread overview]
Message-ID: <90a27f82-ff90-f8ce-ccf3-e1d8909b744d@kernel.org> (raw)
In-Reply-To: <d4cc1576-f4c3-a074-9bf4-937cdd3ff56d@nvidia.com>

On 8/23/23 7:43 AM, Gal Pressman wrote:
>> With veth and namespaces I expect up to 25-30G performance levels,
>> depending on the test. When something fundamental breaks like this patch
>> a drop to < 1G would be a red flag, so there is value to the test.
> Circling back to this, I believe such test already exists:
> tools/testing/selftests/net/udpgro_fwd.sh
> 
> And it indeed fails before Richard's fix.
> 
> I guess all that's left is to actually run these tests 😄?

hmmm... if that is the case, the Makefile shows:

TEST_PROGS += udpgro_fwd.sh

so it should be run. I wonder why one of the many bots did not flag it.

  reply	other threads:[~2023-08-24  3:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-01 16:09 [PATCH v3 0/1] gro: decrease size of CB Richard Gobert
2023-06-01 16:14 ` [PATCH v3 1/1] " Richard Gobert
2023-06-06  7:25   ` Eric Dumazet
2023-06-26  8:55   ` Gal Pressman
2023-06-27 14:21     ` David Ahern
     [not found]       ` <b3908ce2-43e1-b56d-5d1d-48a932a2a016@nvidia.com>
2023-06-28 14:19         ` David Ahern
2023-08-23 14:43           ` Gal Pressman
2023-08-24  3:31             ` David Ahern [this message]
2023-06-29 12:36     ` Richard Gobert
     [not found]       ` <431d8445-9593-73df-d431-d5e76c9085cf@nvidia.com>
2023-06-30 15:39         ` Richard Gobert
2023-07-02 14:41           ` Gal Pressman
2023-07-02 14:46             ` Gal Pressman
2023-07-03 14:23               ` Richard Gobert
2023-07-07 12:31                 ` Richard Gobert
2023-07-09  6:55                   ` Gal Pressman
2023-06-02 14:22 ` [PATCH v3 0/1] " Alexander Lobakin
2023-06-05 13:58   ` Richard Gobert
2023-06-06 13:24     ` Alexander Lobakin
2023-06-06  9:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90a27f82-ff90-f8ce-ccf3-e1d8909b744d@kernel.org \
    --to=dsahern@kernel.org \
    --cc=aleksander.lobakin@intel.com \
    --cc=alexanderduyck@fb.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lixiaoyan@google.com \
    --cc=lucien.xin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardbgobert@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).