netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@kernel.org>
To: Eric Dumazet <edumazet@google.com>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, Kuniyuki Iwashima <kuniyu@amazon.com>,
	Simon Horman <horms@kernel.org>,
	eric.dumazet@gmail.com
Subject: Re: [PATCH net 6/8] vrf: use RCU protection in l3mdev_l3_out()
Date: Fri, 7 Feb 2025 13:45:33 -0700	[thread overview]
Message-ID: <90a599d3-fb7e-4b99-b25b-dfbd44018f8b@kernel.org> (raw)
In-Reply-To: <20250207135841.1948589-7-edumazet@google.com>

On 2/7/25 6:58 AM, Eric Dumazet wrote:
> l3mdev_l3_out() can be called without RCU being held:
> 
> raw_sendmsg()
>  ip_push_pending_frames()
>   ip_send_skb()
>    ip_local_out()
>     __ip_local_out()
>      l3mdev_ip_out()
> 
> Add rcu_read_lock() / rcu_read_unlock() pair to avoid
> a potential UAF.
> 
> Fixes: a8e3e1a9f020 ("net: l3mdev: Add hook to output path")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
>  include/net/l3mdev.h | 2 ++
>  1 file changed, 2 insertions(+)
> 

Reviewed-by: David Ahern <dsahern@kernel.org>


  reply	other threads:[~2025-02-07 20:45 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-07 13:58 [PATCH net 0/8] net: second round to use dev_net_rcu() Eric Dumazet
2025-02-07 13:58 ` [PATCH net 1/8] ndisc: ndisc_send_redirect() must use dev_get_by_index_rcu() Eric Dumazet
2025-02-07 20:41   ` David Ahern
2025-02-10  1:08   ` Kuniyuki Iwashima
2025-02-07 13:58 ` [PATCH net 2/8] ndisc: use RCU protection in ndisc_alloc_skb() Eric Dumazet
2025-02-07 20:41   ` David Ahern
2025-02-10  1:11   ` Kuniyuki Iwashima
2025-02-07 13:58 ` [PATCH net 3/8] neighbour: use RCU protection in __neigh_notify() Eric Dumazet
2025-02-07 20:43   ` David Ahern
2025-02-10  1:14   ` Kuniyuki Iwashima
2025-02-07 13:58 ` [PATCH net 4/8] arp: use RCU protection in arp_xmit() Eric Dumazet
2025-02-07 20:43   ` David Ahern
2025-02-10  1:17   ` Kuniyuki Iwashima
2025-02-07 13:58 ` [PATCH net 5/8] openvswitch: use RCU protection in ovs_vport_cmd_fill_info() Eric Dumazet
2025-02-10  1:22   ` Kuniyuki Iwashima
2025-02-07 13:58 ` [PATCH net 6/8] vrf: use RCU protection in l3mdev_l3_out() Eric Dumazet
2025-02-07 20:45   ` David Ahern [this message]
2025-02-10  1:27   ` Kuniyuki Iwashima
2025-02-07 13:58 ` [PATCH net 7/8] ndisc: extend RCU protection in ndisc_send_skb() Eric Dumazet
2025-02-07 20:46   ` David Ahern
2025-02-10  1:29   ` Kuniyuki Iwashima
2025-02-07 13:58 ` [PATCH net 8/8] ipv6: mcast: extend RCU protection in igmp6_send() Eric Dumazet
2025-02-07 20:50   ` David Ahern
2025-02-10  3:07   ` Kuniyuki Iwashima
2025-02-11  2:20 ` [PATCH net 0/8] net: second round to use dev_net_rcu() patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90a599d3-fb7e-4b99-b25b-dfbd44018f8b@kernel.org \
    --to=dsahern@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuniyu@amazon.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).