From: David Ahern <dsahern@gmail.com>
To: Ido Schimmel <idosch@mellanox.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, roopa@cumulusnetworks.com, mlxsw@mellanox.com
Subject: Re: [PATCH net] ipv6: Honor specified parameters in fibmatch lookup
Date: Wed, 20 Dec 2017 19:54:47 -0700 [thread overview]
Message-ID: <90b66952-d502-5430-e988-fa3e4422ef91@gmail.com> (raw)
In-Reply-To: <20171220102825.28234-1-idosch@mellanox.com>
On 12/20/17 3:28 AM, Ido Schimmel wrote:
> @@ -4327,6 +4321,15 @@ static int inet6_rtm_getroute(struct sk_buff *in_skb, struct nlmsghdr *nlh,
> goto errout;
> }
>
> + if (fibmatch && rt->dst.from) {
> + struct rt6_info *ort = container_of(rt->dst.from,
> + struct rt6_info, dst);
> +
> + dst_hold(&ort->dst);
> + ip6_rt_put(rt);
> + rt = ort;
> + }
> +
> skb = alloc_skb(NLMSG_GOODSIZE, GFP_KERNEL);
> if (!skb) {
> ip6_rt_put(rt);
>
That's going to need a fixup on the net-next merge -- from was moved
from dst to rt6_info. Change wise it looks ok to me.
Acked-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2017-12-21 2:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 10:28 [PATCH net] ipv6: Honor specified parameters in fibmatch lookup Ido Schimmel
2017-12-21 2:54 ` David Ahern [this message]
2017-12-21 16:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90b66952-d502-5430-e988-fa3e4422ef91@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).