From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net] ipv6: Honor specified parameters in fibmatch lookup
Date: Wed, 20 Dec 2017 19:54:47 -0700
Message-ID: <90b66952-d502-5430-e988-fa3e4422ef91@gmail.com>
References: <20171220102825.28234-1-idosch@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: davem@davemloft.net, roopa@cumulusnetworks.com, mlxsw@mellanox.com
To: Ido Schimmel <idosch@mellanox.com>, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf0-f171.google.com ([209.85.192.171]:46509 "EHLO
        mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755928AbdLUCyt (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 20 Dec 2017 21:54:49 -0500
Received: by mail-pf0-f171.google.com with SMTP id c204so13397894pfc.13
        for <netdev@vger.kernel.org>; Wed, 20 Dec 2017 18:54:49 -0800 (PST)
In-Reply-To: <20171220102825.28234-1-idosch@mellanox.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 12/20/17 3:28 AM, Ido Schimmel wrote:
> @@ -4327,6 +4321,15 @@ static int inet6_rtm_getroute(struct sk_buff *in_skb, struct nlmsghdr *nlh,
>  		goto errout;
>  	}
>  
> +	if (fibmatch && rt->dst.from) {
> +		struct rt6_info *ort = container_of(rt->dst.from,
> +						    struct rt6_info, dst);
> +
> +		dst_hold(&ort->dst);
> +		ip6_rt_put(rt);
> +		rt = ort;
> +	}
> +
>  	skb = alloc_skb(NLMSG_GOODSIZE, GFP_KERNEL);
>  	if (!skb) {
>  		ip6_rt_put(rt);
> 


That's going to need a fixup on the net-next merge -- from was moved
from dst to rt6_info. Change wise it looks ok to me.

Acked-by: David Ahern <dsahern@gmail.com>