From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61A3F3EEAEA for ; Mon, 15 Jun 2026 14:27:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781533630; cv=none; b=CC/Ow7l9HcYfHbGkix0rBLzr58KZrU4opjKHWPVODriv6S1jFw4GI7gjsbRQTmtyXSt1++UeLso7YGlXZ8cpD50GL/s2lRQ1ANs7xKA/lPpFTgNDdLoYR4c6pDofeNSbeI+JcLiBv/fVoUicd8Cmr4sbi0hgV2l327IdtB9I15w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781533630; c=relaxed/simple; bh=j7+uubWqjHwfd1F7rjwIRnsarTP5b9XzajE97ofcr2w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aR8bslGYSsVjortMyZh7ffFYuOF2NlqXeh01ZCkHmFxbf8KwmpwVxXIsCpG6zEAF9Ik4TpKyYlQeBYh9ul44/k3QxrKjvZnk9odHRlbkSJtcqmDBWA3YBeOlJcMt46l8X/3Y9ioxQgrVPFTh+HDb102ew+CMoIPgBF6VDd1rHIo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ivOvFk7v; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ivOvFk7v" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-46066e640easo1976780f8f.1 for ; Mon, 15 Jun 2026 07:27:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781533626; x=1782138426; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=m4TXTtdFs/UmLl+HYnmyNiKISILvfZx2SzEmdXfYHcQ=; b=ivOvFk7vOkZBbOFiKdbZF59WTRWUON7NhJvMeWXVYQYGBAojB8h32ET3YxgwrORAIE jMcOp2cBOqsWe+R7alJErluOjvefaane1lGSLQb1t+J7hdRXJgKi297mhQs/nT75OlZx 7Dg3cjzYHgoGWBeGrHwtfcXVFzWVzE2bhVeHQ0NUWcLNPAgjYN69OKMDwmMvIcWqy8MD wpoXZho3dWV9jSAYxi7TbujpSj3l8Qr4/ObmkKcf2fubdiwhBK4eMJawiEqRhBv8YeHA mdIMfhLZXMvSR9z/Nfqr0ILomuuIzmnIfWnHPqpB/oh3yf+3yL8b7h7R8hK86a1u9YX9 HkZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781533626; x=1782138426; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=m4TXTtdFs/UmLl+HYnmyNiKISILvfZx2SzEmdXfYHcQ=; b=mRdPC5lZghhZWgv2wTPHyqPtCBkDRZvHVIJoI4iK//z8VFaL1D3YOFbtMomYF9W3pq axH4kvPGICNLAarzxnpAbydFKd9Gw0oFyvv6KXsCCqi38FIcaEcWYzm1ERBYPIfwo5pm 7p/j8rUlrys99kmwcWYb2oj+Vr+OSq7qbRUueOS7pg8G35NFosV1fxjjvwxG+XDR3CtN RQmdZBqIjxiHkgE3GpcW+F7sfFlqSVyqZKwONyrGMNlCkS4OxytRUAw8XhqD65t+udID UnlchtE78I+FjZGfZb8VLPRPKNKGnZ4dWgnk0kdz4fvYgf69RiN3KzvUr2A3SpI8m8VY YNEQ== X-Gm-Message-State: AOJu0Yz05Ap2/KrjniNQN8GCWy0fJLz0wu1vT5hk0TgJNoV+d7dJe2iO oY70K5d2xG18ZjhioX4ZVzaESs5eXyRTB+SN3w44RPK9kaUX/Vp6IFIw X-Gm-Gg: Acq92OHRbA2Sqijik1gzvlF9h09HlUq3lnQ+P+cRxQI4cZcljpERamwb1aaRxiSKjZi TMiQ8CewGEi2vlhrJ5XMeRUnnAZtRUhotNICfQ5oTKyT75oApq1/RUf52/1unX2M/S19GJ/bojc iAtMORhLaAnksKH4XXzUObtopuLcEzPt874N6B+vENQLioaMEec5uHv6Je6RrEf3ligXgsxTqb/ iIm0xW3HnaqpgMtibMzsjcmUc61Eh/lT7tE46XuQjSHtzzeEkcwn5J+WybdekMNIjdZa5ZILfHL 2GAIIg7dn336B6Df3F42a+JodQVbYJjUPuNbrh6xkSXYcWBHTvDAROw/RVQHtkNw5NdL8LnDZk/ uR2zk3Ak8UaA0izMA4zvSGY9yXjPrwLGgEfmONG/kh1bQm3iS/tHbMFYi5moCuRai9tFQh1Z9gP koebxdvoMNtv3F5KJ3ABkn2kxKFZrpSET/VEbbnA71qNiN+0k3VP/ejIJz1ZlHphyfurod9f8i6 94Ir0uSxFS4MWi4B9U= X-Received: by 2002:a05:6000:2dc2:b0:460:3234:4473 with SMTP id ffacd0b85a97d-4606dbe5c27mr19933766f8f.41.1781533625617; Mon, 15 Jun 2026 07:27:05 -0700 (PDT) Received: from [10.128.10.215] (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f264333sm35600275f8f.4.2026.06.15.07.27.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 07:27:05 -0700 (PDT) Sender: Julian Braha Message-ID: <90f84945-e83f-40a8-8d9e-a477c45579e9@gmail.com> Date: Mon, 15 Jun 2026 15:27:03 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v5 12/15] onsemi: s2500: Add driver support for TS2500 MAC-PHY To: Selvamani.Rajagopal@onsemi.com, Andrew Lunn , Piergiorgio Beruto , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Parthiban Veerasooran , Richard Cochran , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Horman , Jonathan Corbet , Shuah Khan Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, Jerry Ray References: <20260614-s2500-mac-phy-support-v5-0-89874b72f725@onsemi.com> <20260614-s2500-mac-phy-support-v5-12-89874b72f725@onsemi.com> Content-Language: en-US From: Julian Braha In-Reply-To: <20260614-s2500-mac-phy-support-v5-12-89874b72f725@onsemi.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Selvamani, On 6/14/26 18:00, Selvamani Rajagopal via B4 Relay wrote: > diff --git a/drivers/net/ethernet/onsemi/Kconfig b/drivers/net/ethernet/onsemi/Kconfig > new file mode 100644 > index 000000000000..8d72194151ea > --- /dev/null > +++ b/drivers/net/ethernet/onsemi/Kconfig > @@ -0,0 +1,21 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# onsemi network device configuration > +# > + > +config NET_VENDOR_ONSEMI > + bool "onsemi network devices" > + help > + If you have a network card belonging to this class, say Y. > + > + Note that the answer to this question doesn't directly affect the > + kernel: saying N will just cause the configurator to skip all > + the questions about onsemi ethernet devices. If you say Y, you > + will be asked for your specific card in the following questions. > + > +if NET_VENDOR_ONSEMI > + > +source "drivers/net/ethernet/onsemi/s2500/Kconfig" > + > +endif # NET_VENDOR_ONSEMI When you put the 'if NET_VENDOR_ONSEMI' around the 'source', you're making it a dependency on every config option in that sourced Kconfig. > diff --git a/drivers/net/ethernet/onsemi/s2500/Kconfig b/drivers/net/ethernet/onsemi/s2500/Kconfig > new file mode 100644 > index 000000000000..f2e8d5d1429d > --- /dev/null > +++ b/drivers/net/ethernet/onsemi/s2500/Kconfig > @@ -0,0 +1,21 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# onsemi S2500 Driver Support > +# > + > +if NET_VENDOR_ONSEMI > + > +config S2500_MACPHY > + tristate "S2500 support" > + depends on SPI > + select NCN26000_PHY > + select OA_TC6 > + help > + Support for the onsemi TS2500 MACPHY Ethernet chip. > + It works under the framework that conform to OPEN Alliance > + 10BASE-T1x Serial Interface specification. > + > + To compile this driver as a module, choose M here. The module will be > + called s2500. > + > +endif # NET_VENDOR_ONSEMI Which means that when you add 'if NET_VENDOR_ONSEMI' again inside the sourced Kconfig, it's a duplicate dependency. I think putting the if-endif in either place is fine, but it's redundant to do it twice. You could maybe consider using a comment for the second instance instead. - Julian Braha