From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH v3 2/3] selftests/bpf: Makefile: add include path Date: Wed, 2 May 2018 17:43:58 +0200 Message-ID: <90f906d1-42e3-83f1-ba4e-ec56a9ba6514@iogearbox.net> References: <20180502110505.7n567iqy6duuzjbs@vm4> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Sirio Balmelli Return-path: Received: from www62.your-server.de ([213.133.104.62]:33752 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751175AbeEBPoA (ORCPT ); Wed, 2 May 2018 11:44:00 -0400 In-Reply-To: <20180502110505.7n567iqy6duuzjbs@vm4> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 05/02/2018 01:05 PM, Sirio Balmelli wrote: > On some systems selftests fail to build, missing the following headers: > > asm/byteorder.h > asm/socket.h > asm/swab.h > > In the specific case of Ubuntu, this is because the files are in > '/usr/include/x86_64-linux-gnu' (see ) > which is both architecture- and distro-specific. > > The solution is to add $(KERNEL)/usr/include to the Makefile, > so the build references these from the current kernel build > and not the running system. > > Signed-off-by: Sirio Balmelli > --- > tools/testing/selftests/bpf/Makefile | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile > index 9d76218..1ec09c6 100644 > --- a/tools/testing/selftests/bpf/Makefile > +++ b/tools/testing/selftests/bpf/Makefile > @@ -84,7 +84,10 @@ else > CPU ?= generic > endif > > -CLANG_FLAGS = -I. -I./include/uapi -I../../../include/uapi \ > +# we are in 'tools/testing/selftests/bpf' > +KERNEL=../../../.. > +TOOLS=../../.. > +CLANG_FLAGS = -I. -I./include/uapi -I$(TOOLS)/include/uapi -I$(KERNEL)/usr/include \ > -Wno-compare-distinct-pointer-types First patch in the series looks good to me, thanks Sirio! Problem with this one is still as described earlier in: http://patchwork.ozlabs.org/patch/906505/ This will break people's setup and build bots since they expect headers to be available from tools infra and not -I/usr/include/ via headers_install, so adding the latter is not possible (unless Arnaldo agrees to rework the whole tools include infra in a better way). This means the only other option we have is to pull them into tools/ instead, even if this results in a lot of duplication, but whether we like it or not that is the way the tools/include stuff was designed along with perf, meaning unless there's a fundamental rework, we will have to stick to it. Thanks, Daniel > $(OUTPUT)/test_l4lb_noinline.o: CLANG_FLAGS += -fno-inline >