From: David Woodhouse <dwmw2@infradead.org>
To: Richard Cochran <richardcochran@gmail.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: Wen Gu <guwen@linux.alibaba.com>,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, xuanzhuo@linux.alibaba.com,
dust.li@linux.alibaba.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH net-next v4] ptp: add Alibaba CIPU PTP clock driver
Date: Thu, 21 Aug 2025 21:12:48 +0100 [thread overview]
Message-ID: <91008c3cd2502b3726992b0f490aac54a1efa186.camel@infradead.org> (raw)
In-Reply-To: <aKd8AtiXq0o09pba@hoboy.vegasvil.org>
[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]
On Thu, 2025-08-21 at 13:05 -0700, Richard Cochran wrote:
> On Fri, Aug 15, 2025 at 11:38:14AM -0700, Jakub Kicinski wrote:
>
> > Maybe it's just me, but in general I really wish someone stepped up
> > and created a separate subsystem for all these cloud / vm clocks.
> > They have nothing to do with PTP. In my mind PTP clocks are simple HW
> > tickers on which we build all the time related stuff. While this driver
> > reports the base year for the epoch and leap second status via sysfs.
>
> Yeah, that is my feeling as well.
Agreed. While vmclock is presented as a PTP clock for compatibility,
it's more than that because it can do better than simply giving a
single precise point in time. It actually tells the guest the precise
relationship between the hardware counter and real time, much like the
private data structure exposed from the kernel to vDSO gettimeofday.
We should work on having the kernel consume that *directly* and feed
its CLOCK_REALTIME with it. Having hundreds of guests on the same host
all recalculate the same thing based on a set of points in time,
obtained through /dev/ptpX or otherwise, is just daft.
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5069 bytes --]
next prev parent reply other threads:[~2025-08-21 20:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 11:53 [PATCH net-next v4] ptp: add Alibaba CIPU PTP clock driver Wen Gu
2025-08-15 18:38 ` Jakub Kicinski
2025-08-15 18:43 ` David Woodhouse
2025-08-19 3:00 ` Wen Gu
2025-08-16 3:52 ` Wen Gu
2025-08-16 15:37 ` Andrew Lunn
2025-08-17 3:01 ` Wen Gu
2025-08-17 15:56 ` Andrew Lunn
2025-08-18 3:04 ` Wen Gu
2025-08-18 16:05 ` Jakub Kicinski
2025-08-21 20:05 ` Richard Cochran
2025-08-21 20:12 ` David Woodhouse [this message]
2025-08-22 2:07 ` Wen Gu
2025-08-22 7:43 ` David Woodhouse
2025-08-30 8:41 ` Wen Gu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91008c3cd2502b3726992b0f490aac54a1efa186.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dust.li@linux.alibaba.com \
--cc=edumazet@google.com \
--cc=guwen@linux.alibaba.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).