From: David Ahern <dsahern@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>
Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
netdev@vger.kernel.org, Juliusz Chroboczek <jch@irif.fr>
Subject: Re: [PATCH net v2 2/2] selftests/net: Add icmp.sh for testing ICMP dummy address responses
Date: Fri, 18 Jun 2021 07:44:14 -0600 [thread overview]
Message-ID: <91915a59-2e69-112d-6fcc-5ba07ad6d313@gmail.com> (raw)
In-Reply-To: <20210618110436.91700-2-toke@redhat.com>
On 6/18/21 5:04 AM, Toke Høiland-Jørgensen wrote:
> This adds a new icmp.sh selftest for testing that the kernel will respond
> correctly with an ICMP unreachable message with the dummy (192.0.0.8)
> source address when there are no IPv4 addresses configured to use as source
> addresses.
>
> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
> ---
> tools/testing/selftests/net/icmp.sh | 74 +++++++++++++++++++++++++++++
> 1 file changed, 74 insertions(+)
> create mode 100755 tools/testing/selftests/net/icmp.sh
>
Reviewed-by: David Ahern <dsahern@kernel.org>
Thanks, Toke.
next prev parent reply other threads:[~2021-06-18 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 11:04 [PATCH net v2 1/2] icmp: don't send out ICMP messages with a source address of 0.0.0.0 Toke Høiland-Jørgensen
2021-06-18 11:04 ` [PATCH net v2 2/2] selftests/net: Add icmp.sh for testing ICMP dummy address responses Toke Høiland-Jørgensen
2021-06-18 13:44 ` David Ahern [this message]
2021-06-18 19:20 ` [PATCH net v2 1/2] icmp: don't send out ICMP messages with a source address of 0.0.0.0 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91915a59-2e69-112d-6fcc-5ba07ad6d313@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=jch@irif.fr \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).