Netdev List
 help / color / mirror / Atom feed
From: "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
To: "kuba@kernel.org" <kuba@kernel.org>
Cc: "patryk.malek@intel.com" <patryk.malek@intel.com>,
	"sassmann@redhat.com" <sassmann@redhat.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"Kuruvinakunnel, George" <george.kuruvinakunnel@intel.com>
Subject: Re: [PATCH net-next 02/12] iavf: Add change MTU message
Date: Mon, 29 Nov 2021 18:43:26 +0000	[thread overview]
Message-ID: <91d61a00c15af2ad177cc88fa532fb911fd8484d.camel@intel.com> (raw)
In-Reply-To: <20211124154606.47936e48@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

On Wed, 2021-11-24 at 15:46 -0800, Jakub Kicinski wrote:
> On Wed, 24 Nov 2021 09:16:42 -0800 Tony Nguyen wrote:
> > Add a netdev_info log entry in case of a change of MTU so that user
> > is
> > notified about this change in the same manner as in case of pf
> > driver.
> 
> Why is this an important piece of information, tho? Other major
> vendors
> don't print this.

I was going to say this was to match the behaviour of our other
drivers, however, after looking at the others, they are dev_dbgs. Would
that change work for you?

Thanks,
Tony


  reply	other threads:[~2021-11-29 18:53 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 17:16 [PATCH net-next 00/12][pull request] 40GbE Intel Wired LAN Driver Updates 2021-11-24 Tony Nguyen
2021-11-24 17:16 ` [PATCH net-next 01/12] iavf: restore MSI state on reset Tony Nguyen
2021-11-24 23:42   ` Jakub Kicinski
2021-11-29 18:41     ` Nguyen, Anthony L
2021-11-24 17:16 ` [PATCH net-next 02/12] iavf: Add change MTU message Tony Nguyen
2021-11-24 23:46   ` Jakub Kicinski
2021-11-29 18:43     ` Nguyen, Anthony L [this message]
2021-11-30  0:53       ` Jakub Kicinski
2021-11-24 17:16 ` [PATCH net-next 04/12] iavf: return errno code instead of status code Tony Nguyen
2021-11-24 17:16 ` [PATCH net-next 05/12] iavf: don't be so alarming Tony Nguyen
2021-11-25  6:45   ` Stefan Assmann
2021-11-29 18:44     ` Nguyen, Anthony L
2021-11-24 17:16 ` [PATCH net-next 06/12] iavf: Add trace while removing device Tony Nguyen
2021-11-24 23:48   ` Jakub Kicinski
2021-11-25  6:50     ` Stefan Assmann
2021-11-25 15:13       ` Jakub Kicinski
2021-11-25 15:43         ` Stefan Assmann
2021-11-25 15:57           ` Jakub Kicinski
2021-11-25 16:46             ` Stefan Assmann
2021-11-24 17:16 ` [PATCH net-next 07/12] iavf: Enable setting RSS hash key Tony Nguyen
2021-11-24 17:16 ` [PATCH net-next 08/12] iavf: Refactor iavf_mac_filter struct memory usage Tony Nguyen
2021-11-24 23:49   ` Jakub Kicinski
2021-11-26 10:13     ` Jagielski, Jedrzej
2021-11-24 17:16 ` [PATCH net-next 09/12] iavf: Fix static code analysis warning Tony Nguyen
2021-11-24 17:16 ` [PATCH net-next 10/12] iavf: Refactor text of informational message Tony Nguyen
2021-11-24 17:16 ` [PATCH net-next 11/12] iavf: Refactor string format to avoid static analysis warnings Tony Nguyen
2021-11-24 17:16 ` [PATCH net-next 12/12] iavf: Fix displaying queue statistics shown by ethtool Tony Nguyen
2021-11-24 23:42 ` [PATCH net-next 00/12][pull request] 40GbE Intel Wired LAN Driver Updates 2021-11-24 Jakub Kicinski
2021-11-29 18:46   ` Nguyen, Anthony L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91d61a00c15af2ad177cc88fa532fb911fd8484d.camel@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=george.kuruvinakunnel@intel.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=patryk.malek@intel.com \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox