From: David Ahern <dsahern@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>, netdev@vger.kernel.org
Cc: ikomyagin@gmail.com
Subject: Re: [PATCH iproute2 0/3] ss: fix slab statistics
Date: Sun, 25 Feb 2018 21:02:23 -0700 [thread overview]
Message-ID: <91d6ea50-18cf-52b4-9ef6-9d0101f3bcc9@gmail.com> (raw)
In-Reply-To: <20180224191607.23892-1-stephen@networkplumber.org>
On 2/24/18 12:16 PM, Stephen Hemminger wrote:
> The ss -s command has been broken in several places since the
> 2.6.13 kernel. The slab values it is looking for have changed
> names and kernel started merging the values (see kernel patch
> for fixing that).
>
> Stephen Hemminger (3):
> ss: drop unused slabstat for skb's
> ss: convert socket statistics to unsigned
> ss: update slabinfo names and sum IPv4 and IPv6
>
> misc/ss.c | 125 +++++++++++++++++++++++++++++++-------------------------------
> 1 file changed, 62 insertions(+), 63 deletions(-)
>
LGTM. Acked-by: David Ahern <dsahern@gmail.com>
prev parent reply other threads:[~2018-02-26 4:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 19:16 [PATCH iproute2 0/3] ss: fix slab statistics Stephen Hemminger
2018-02-24 19:16 ` [PATCH iproute2 1/3] ss: drop unused slabstat for skb's Stephen Hemminger
2018-02-24 19:16 ` [PATCH iproute2 2/3] ss: convert socket statistics to unsigned Stephen Hemminger
2018-02-24 19:16 ` [PATCH iproute2 3/3] ss: update slabinfo names and sum IPv4 and IPv6 Stephen Hemminger
2018-02-26 4:02 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91d6ea50-18cf-52b4-9ef6-9d0101f3bcc9@gmail.com \
--to=dsahern@gmail.com \
--cc=ikomyagin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).