From: Paolo Abeni <pabeni@redhat.com>
To: Stefano Radaelli <stefano.radaelli21@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Stefano Radaelli <stefano.r@variscite.com>,
Xu Liang <lxu@maxlinear.com>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net v1] net: phy: mxl-86110: Add power management and soft reset support
Date: Tue, 23 Dec 2025 12:28:06 +0100 [thread overview]
Message-ID: <91d7740a-b340-449d-98e3-d3cf0aae5f78@redhat.com> (raw)
In-Reply-To: <20251216162534.141825-1-stefano.r@variscite.com>
On 12/16/25 5:25 PM, Stefano Radaelli wrote:
> Implement soft_reset, suspend, and resume callbacks using
> genphy_soft_reset(), genphy_suspend(), and genphy_resume()
> to fix PHY initialization and power management issues.
>
> The soft_reset callback is needed to properly recover the PHY after an
> ifconfig down/up cycle. Without it, the PHY can remain in power-down
> state, causing MDIO register access failures during config_init().
> The soft reset ensures the PHY is operational before configuration.
>
> The suspend/resume callbacks enable proper power management during
> system suspend/resume cycles.
>
> Fixes: b2908a989c59 ("net: phy: add driver for MaxLinear MxL86110 PHY")
> Signed-off-by: Stefano Radaelli <stefano.r@variscite.com>
You need to add a suitable From: tag at the body start, or use the same
email address as the sender, whatever you prefer.
Also the resume/callback bits are IMHO more new features than fixes, but
I will not push back hard against them.
Thanks,
Paolo
prev parent reply other threads:[~2025-12-23 11:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 16:25 [PATCH net v1] net: phy: mxl-86110: Add power management and soft reset support Stefano Radaelli
2025-12-23 11:28 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91d7740a-b340-449d-98e3-d3cf0aae5f78@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lxu@maxlinear.com \
--cc=netdev@vger.kernel.org \
--cc=stefano.r@variscite.com \
--cc=stefano.radaelli21@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).