From: Edward Cree <ecree.xilinx@gmail.com>
To: Alexey Dobriyan <adobriyan@gmail.com>, torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
vgupta@synopsys.com, linux-snps-arc@lists.infradead.org,
jiri@nvidia.com, idosch@nvidia.com, netdev@vger.kernel.org,
Jason@zx2c4.com, mchehab@kernel.org
Subject: Re: [PATCH 10/11] pragma once: delete few backslashes
Date: Thu, 4 Mar 2021 14:22:24 +0000 [thread overview]
Message-ID: <91f4ba8b-38a0-dfcf-1fec-31410a802f5f@gmail.com> (raw)
In-Reply-To: <YDvNSg9OPv7JqfRS@localhost.localdomain>
On 28/02/2021 17:05, Alexey Dobriyan wrote:
> From 251ca5673886b5bb0a42004944290b9d2b267a4a Mon Sep 17 00:00:00 2001
> From: Alexey Dobriyan <adobriyan@gmail.com>
> Date: Fri, 19 Feb 2021 13:37:24 +0300
> Subject: [PATCH 10/11] pragma once: delete few backslashes
>
> Some macros contain one backslash too many and end up being the last
> macro in a header file. When #pragma once conversion script truncates
> the last #endif and whitespace before it, such backslash triggers
> a warning about "OMG file ends up in a backslash-newline".
>
> Needless to say I don't want to handle another case in my script,
> so delete useless backslashes instead.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> arch/arc/include/asm/cacheflush.h | 2 +-
> drivers/net/ethernet/mellanox/mlxsw/item.h | 2 +-
> include/linux/once.h | 2 +-
> include/media/drv-intf/exynos-fimc.h | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arc/include/asm/cacheflush.h b/arch/arc/include/asm/cacheflush.h
> index e201b4b1655a..46704c341b17 100644
> --- a/arch/arc/include/asm/cacheflush.h
> +++ b/arch/arc/include/asm/cacheflush.h
> @@ -112,6 +112,6 @@ do { \
> } while (0)
>
> #define copy_from_user_page(vma, page, vaddr, dst, src, len) \
> - memcpy(dst, src, len); \
> + memcpy(dst, src, len)
> This changebar also removes a semicolon.
It looks plausibly correct, but the commit message ought to mention it.
-ed
next prev parent reply other threads:[~2021-03-04 14:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <YDvLYzsGu+l1pQ2y@localhost.localdomain>
2021-02-28 16:58 ` [PATCH 01/11] pragma once: delete include/linux/atm_suni.h Alexey Dobriyan
2021-02-28 19:05 ` Jakub Kicinski
2021-02-28 17:05 ` [PATCH 10/11] pragma once: delete few backslashes Alexey Dobriyan
2021-03-01 8:54 ` Ido Schimmel
2021-03-02 19:00 ` Vineet Gupta
2021-03-04 14:22 ` Edward Cree [this message]
2021-03-23 10:09 ` Pavel Machek
2021-02-28 17:11 ` [PATCH 12/11] pragma once: scripted treewide conversion Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91f4ba8b-38a0-dfcf-1fec-31410a802f5f@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=Jason@zx2c4.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=idosch@nvidia.com \
--cc=jiri@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).