From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48A2B3E1730 for ; Tue, 12 May 2026 13:32:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778592743; cv=none; b=YF2aEugGmtAbJ80IQ8IuYgL7V+/O+JZuDiZlVHv5e6wxEySzzIADJneLAcg8z8EbLZeU0hQYhMmrSFgLDU8pi3cxEicK5Y2zId83pEcgu9dkKQhg6WjFw16+I4zMRYNCIjP3krSrcC4h6pt1NHaYilAykSAjqwGHAN9RloxL7q0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778592743; c=relaxed/simple; bh=2a0VEEh++ToCnDM9Nu78zdEEiYidXVyrGVfaJTq+Q0E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FFDelYIhTOYo4Mx4JzRecEKq2x2cEY506ekcDUvgh0BF1QCeBXfKywViHj8PlflDjSBZ+16XLx36BZVMHFwGvvwd4JTiA+I0VPZfjihuizRhR6YqELDrKQavg5pOi6d398Fs+1WxOkarfXeQ83Yjq/lRl1WDmS2prHBNbFLoxy8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=MdHX5i1Q; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="MdHX5i1Q" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id B01A74E42C83; Tue, 12 May 2026 13:32:20 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 7972F60646; Tue, 12 May 2026 13:32:20 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id F14E311AF874F; Tue, 12 May 2026 15:32:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1778592739; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=wbVp7XXps13Zl+aS41wr/B33E+sqORYJAXToq+Zs+Ik=; b=MdHX5i1Q8NssOZq+1LruwkFS6kyKJ4OV8H3ot/+3hAFAfhsbunczThxiQWnNZxANw74X5V zMeWluvrhl//mYxDzfVc8KUIEG2cgEtqxBQwRd0gum7+HWwrEWMcjbR3LxwWZRn+An5AOv eeuWQ0VNbwCRZfnIFcvM662lvqfdPsCQX9dAGDMVPUSZwve68pLbzyUlgRxquewNv/5RiH 4YGuBgmUIvBzR3S+jXfVMHogC/zTTKUukH7tlUQMR4g51xa/K1Ip8GTmRM3oyN9gENMmKi 6V5o65XlpWme6f4JAQNwmcqu5B6Y2xvMozTc8Be7416H7/3k5w38FxkfDlI0zw== Message-ID: <91f86e6c-6013-42cc-8a4b-2b32093b9eae@bootlin.com> Date: Tue, 12 May 2026 15:32:12 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [net-next v3 2/3] net: motorcomm: phy: set drive strength in YT8531s RGMII To: Minda Chen , Frank , Andrew Lunn , Heiner Kallweit , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org References: <20260508094522.3952-1-minda.chen@starfivetech.com> <20260508094522.3952-3-minda.chen@starfivetech.com> Content-Language: en-US From: Maxime Chevallier In-Reply-To: <20260508094522.3952-3-minda.chen@starfivetech.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 5/8/26 11:45, Minda Chen wrote: > Set RXD and RX CLK pin drive strength while in YT8531s connect > with RGMII. > > Signed-off-by: Minda Chen > --- > drivers/net/phy/motorcomm.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c > index c66804537aa2..ebc24f51e626 100644 > --- a/drivers/net/phy/motorcomm.c > +++ b/drivers/net/phy/motorcomm.c > @@ -1698,6 +1698,11 @@ static int yt8521_config_init(struct phy_device *phydev) > if (ret < 0) > goto err_restore_page; > } > + > + if (phydev->drv->phy_id == PHY_ID_YT8531S && > + phy_interface_is_rgmii(phydev)) > + ret = yt8531_set_ds(phydev); Minor detail if you re-spin, there's already a check for the interface being RGMII a bit above in the same function, but it's written as : /* set rgmii delay mode */ if (phydev->interface != PHY_INTERFACE_MODE_SGMII) ... could be a good idea to change that check to a more explicit call to phy_interface_is_rgmii(), or even add the drive-strength configuration under the same block, provided the order of operation doesn't matter w.r.t the pll/auto-sleep configuration. Maxime > + > err_restore_page: > return phy_restore_page(phydev, old_page, ret); > }