netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taehee Yoo <ap420073@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH net] amt: fix gateway mode stuck
Date: Tue, 17 May 2022 09:18:21 +0900	[thread overview]
Message-ID: <9208ca5a-cdc8-9b73-a024-9b7cba14dfee@gmail.com> (raw)
In-Reply-To: <20220516161001.78b3b49b@kernel.org>

On 5/17/22 08:10, Jakub Kicinski wrote:

Hi Jakub,

Thanks a lot for your review!

> On Sat, 14 May 2022 13:13:46 +0000 Taehee Yoo wrote:
>> -			if (amt_advertisement_handler(amt, skb))
>> +			err = amt_advertisement_handler(amt, skb);
>> +			if (err)
>>   				amt->dev->stats.rx_dropped++;
>> -			goto out;
>> +			break;
> 
> There's another amt->dev->stats.rx_dropped++; before the end of this
> function which now won't be skipped, I think you're counting twice.
This is intended.
It skips a remaining handling of advertisement message.
So, I think a memory leak would occur at this point, so I added.

Thanks!
Taehee Yoo

      reply	other threads:[~2022-05-17  0:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-14 13:13 [PATCH net] amt: fix gateway mode stuck Taehee Yoo
2022-05-16 23:10 ` Jakub Kicinski
2022-05-17  0:18   ` Taehee Yoo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9208ca5a-cdc8-9b73-a024-9b7cba14dfee@gmail.com \
    --to=ap420073@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).