From: SF Markus Elfring <elfring@users.sourceforge.net>
To: netdev@vger.kernel.org, Casey Leedom <leedom@chelsio.com>,
Ganesh Goudar <ganeshgr@chelsio.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 3/6] cxgb4vf: Adjust five checks for null pointers
Date: Thu, 4 May 2017 22:33:22 +0200 [thread overview]
Message-ID: <921bc451-3b7b-1d77-72eb-755061a7fe09@users.sourceforge.net> (raw)
In-Reply-To: <a3216042-2461-b397-dfa1-1de178d58513@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 4 May 2017 21:20:25 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written !…
Thus fix the affected source code places.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
index 9c2690aeb32b..682e844c5a7d 100644
--- a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
@@ -491,7 +491,7 @@ static int fwevtq_handler(struct sge_rspq *rspq, const __be64 *rsp,
break;
}
tq = s->egr_map[eq_idx];
- if (unlikely(tq == NULL)) {
+ if (unlikely(!tq)) {
dev_err(adapter->pdev_dev,
"Egress Update QID %d TXQ=NULL\n", qid);
break;
@@ -2939,7 +2939,7 @@ static int cxgb4vf_pci_probe(struct pci_dev *pdev,
*/
netdev = alloc_etherdev_mq(sizeof(struct port_info),
MAX_PORT_QSETS);
- if (netdev == NULL) {
+ if (!netdev) {
t4vf_free_vi(adapter, viid);
err = -ENOMEM;
goto err_free_dev;
@@ -3053,7 +3053,7 @@ static int cxgb4vf_pci_probe(struct pci_dev *pdev,
for_each_port(adapter, pidx) {
struct port_info *pi = netdev_priv(adapter->port[pidx]);
netdev = adapter->port[pidx];
- if (netdev == NULL)
+ if (!netdev)
continue;
netif_set_real_num_tx_queues(netdev, pi->nqsets);
@@ -3120,7 +3120,7 @@ static int cxgb4vf_pci_probe(struct pci_dev *pdev,
err_free_dev:
for_each_port(adapter, pidx) {
netdev = adapter->port[pidx];
- if (netdev == NULL)
+ if (!netdev)
continue;
pi = netdev_priv(netdev);
t4vf_free_vi(adapter, pi->viid);
@@ -3197,7 +3197,7 @@ static void cxgb4vf_pci_remove(struct pci_dev *pdev)
struct net_device *netdev = adapter->port[pidx];
struct port_info *pi;
- if (netdev == NULL)
+ if (!netdev)
continue;
pi = netdev_priv(netdev);
--
2.12.2
next prev parent reply other threads:[~2017-05-04 20:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 20:30 [PATCH 0/6] cxgb4: Fine-tuning for some function implementations SF Markus Elfring
2017-05-04 20:31 ` [PATCH 1/6] cxgb4vf: Use seq_putc() in mboxlog_show() SF Markus Elfring
2017-05-04 20:32 ` [PATCH 2/6] cxgb4vf: Combine substrings for 24 messages SF Markus Elfring
2017-05-04 20:33 ` SF Markus Elfring [this message]
2017-05-04 20:34 ` [PATCH 4/6] cxgb4: Replace seven seq_puts() calls by seq_putc() SF Markus Elfring
2017-05-04 20:35 ` [PATCH 5/6] cxgb4: Use seq_puts() in cim_qcfg_show() SF Markus Elfring
2017-05-04 20:36 ` [PATCH 6/6] cxgb4: Combine substrings for two messages SF Markus Elfring
2017-05-09 9:40 ` [PATCH 0/6] cxgb4: Fine-tuning for some function implementations Ganesh GR
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=921bc451-3b7b-1d77-72eb-755061a7fe09@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=ganeshgr@chelsio.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=leedom@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).