Re: [PATCH net 1/1] ovpn: fix race between deleting interface and adding new peer

[Antonio Quartulli <antonio@openvpn.net>]

On 23/04/2026 14:16, Antonio Quartulli wrote:
> On 23/04/2026 04:20, Jakub Kicinski wrote:
>> On Wed, 22 Apr 2026 14:32:42 +0200 Antonio Quartulli wrote:
>>> +    /* Prevent adding new peers while destroying the ovpn interface.
>>> +     * Failing to do so would end up holding the device reference
>>> +     * endlessly hostage of the new peer object with no chance of
>>> +     * release..
>>> +     */
>>> +    if (ovpn->dev->reg_state >= NETREG_UNREGISTERING)
>>> +        return -ENODEV;
>>
>> AI review suggests wrapping reg_state read in READ_ONCE(), I think
>> that's legit. Also nit: I think > or != REGISTERED would be more
>> idiomatic than comparing >= UNREGSITERING ?
> 
> Agreed on READ_ONCE. Will fix it.
> 
> As for your second point, I am fine with "!= REGISTERED" as that's the 
> only state we should be accepting new peers in any case.
> 
>>
>> If you agree make sure Sashiko doesn't complain about anything else
>> once it's public:
>> https://sashiko.dev/#/patchset/20260422123242.530882-2- 
>> antonio@openvpn.net
> 
> Is there any way to get earlier access to these reviews? (at least for 
> patches somehow related to me/ovpn)
> 

Dang! sashiko reminded me that I should swap cancel_delayed_work_sync 
with disable_delayed_work_sync. Will fix that.


As for the second remarks..It has convincing arguments, but I need some 
more time to think about it.

Sabrina, do you have an opinion?

Cheers,


> 
> Thanks!
> Regards,
> 

-- 
Antonio Quartulli
OpenVPN Inc.