From: Florian Fainelli <f.fainelli@gmail.com>
To: David Miller <davem@davemloft.net>, yoshihiro.shimoda.uh@renesas.com
Cc: andrew@lunn.ch, netdev@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 0/2] net: phy: micrel: add tobling phy reset
Date: Mon, 3 Dec 2018 15:24:43 -0800 [thread overview]
Message-ID: <92358866-e231-15e7-84f4-86a6fa51ed49@gmail.com> (raw)
In-Reply-To: <20181203.152057.61263535375452379.davem@davemloft.net>
On 12/3/18 3:20 PM, David Miller wrote:
> From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Date: Wed, 28 Nov 2018 09:02:41 +0000
>
>> This patch set is for R-Car Gen3 Salvator-XS boards. If we do
>> the following method, the phy cannot link up correctly.
>>
>> 1) Kernel boots by using initramfs.
>> --> No open the nic, so phy_device_register() and phy_probe()
>> deasserts the reset.
>> 2) Kernel enters the suspend.
>> --> So, keep the reset signal as deassert.
>> --> On R-Car Salvator-XS board, unfortunately, the board power is
>> turned off.
>> 3) Kernel returns from suspend.
>> 4) ifconfig eth0 up
>> --> Then, since edge signal of the reset doesn't happen,
>> it cannot link up.
>> 5) ifconfig eth0 down
>> 6) ifconfig eth0 up
>> --> In this case, it can link up.
>>
>> When resolving this issue after I got feedback from Andrew and Heiner,
>> I found an issue that the phy_device.c didn't call phy_resume()
>> if the PHY was not attached. So, patch 1 fixes it and add toggling
>> the phy reset to the micrel phy driver.
>>
>> Changes from v1 (as RFC):
>> - No remove the current code of phy_device.c to avoid any side effects.
>> - Fix the mdio_bus_phy_resume() in phy_device.c.
>> - Add toggling the phy reset in micrel.c if the PHY is not attached.
>
> Series applied, thank you.
Meh! I guess we should be faster at reviewing stuff :/
--
Florian
next prev parent reply other threads:[~2018-12-03 23:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 9:02 [PATCH v2 0/2] net: phy: micrel: add tobling phy reset Yoshihiro Shimoda
2018-11-28 9:02 ` [PATCH v2 1/2] net: phy: Fix not to call phy_resume() if PHY is not attached Yoshihiro Shimoda
2018-11-28 9:02 ` [PATCH v2 2/2] net: phy: micrel: add toggling phy reset " Yoshihiro Shimoda
2018-12-03 23:20 ` [PATCH v2 0/2] net: phy: micrel: add tobling phy reset David Miller
2018-12-03 23:24 ` Florian Fainelli [this message]
2018-12-03 23:37 ` David Miller
2018-12-04 10:43 ` Andrew Lunn
2018-12-04 16:49 ` David Miller
2018-12-17 10:46 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92358866-e231-15e7-84f4-86a6fa51ed49@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).