From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ECEC328616 for ; Mon, 26 Jan 2026 11:49:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769428180; cv=none; b=hXLCyzzGYA70r2xaCjx42RXFtflSqFxjBDwAJ744Ip3FMlQr89zwZ9TX2PC8SA97zKOwzVRvlJg47RUZrBHCAKLrvagG2k3mD+prpR4+jdKgIm2qJ8kvwsp9pNcA/c1PfZbMK9057p4PLDPkQMOoqJRQk+Zn4Pv9hBfRDKntuq8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769428180; c=relaxed/simple; bh=9yn2gy4stahnnhoif2MbmULokXbFyhugTFcvVCHDtZU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XoV1penxoZXBWY4UpZToKgGVB73okP9BgXjDYvaHg+h0XdosAfsqLtxR1m5Ay7MI/tnqFSwGGE4XbFVE1GxbAKI5LXdD9DqIi/Bz8aIRsESDXgtWgigxy+EoqowLxahPw/nkQeN8hmCQDkTsDRzEV98vv2nawzLh3PCoxEG9G4Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=g8OvjCRp; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="g8OvjCRp" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-47ee4338e01so24998385e9.2 for ; Mon, 26 Jan 2026 03:49:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1769428177; x=1770032977; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NOhLAj2giVSLA0OsJBFJXkMMrU18g2uT51Qc0Cqc3Y8=; b=g8OvjCRpuDAdCP1praM4sVBUmhqpw5qU5Zsf1mQNurHrTNHm33j6SeoO9IE/wEGbqr Bnsox7ue47l6/PK1Vbhjwi0KCZUyGqxsLyi4ea+93NKwydwOuq6yb4/k9G2ho/EyVTqe obBR7NPTVMqIHdfvNnqhcE6/EOKlH6F9JtDuiA2NYRb+n/ryWm4qbzMqy3c1EYOe4DPP NIsurtCqHdv7VYMMbf+zgC+79ZC98R6VuRtypnKKAaa2EBtl/kQUcEzlsJfNNyJDABPM RNQ0W3R0KQf8eLOf1aPIWsneQpwjyDXxgCSI7iPXUyFUNd8vsW9x+Iqkzzfz81T0Bxu3 HtxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769428177; x=1770032977; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NOhLAj2giVSLA0OsJBFJXkMMrU18g2uT51Qc0Cqc3Y8=; b=Ug/PvXRRqVe0qHRi5vhqpbeDl61DD5/KYRuX6GRTVfmIurWOMXgK35bnarbfyShzFM lszByJVXhIAUqmdyNuMJBMTQpwwon4xiX4c0DGMV4BzkeQv37gMIG0nD0lDMbQwBrSX6 72ypHCCDW3QiTvOSh7nnAciHuaJZhYyvYjB8Icube3xN+9mJmh5WoNtCeD0e8wmYFBDr P9AupvWtA9ctVwcnbFwyDE2TD+m3qub0PuO74uP+KV2Z3w4eV4Ydyko/cpwksR/UYMgh 1uoPzTkJ+JzKEEmPC9lwxm67JpN9uRibzh2hGa0LkCbXJ+P4BRcVGixzwFckYDbMvXOL WhdQ== X-Forwarded-Encrypted: i=1; AJvYcCWKG/Lk2sQFYA9sMXTWXiCNof7vC2ciJVMVyOQXWdxyHRLW+wf4Jpk2T21Xzb7TT6Oxq0seIj4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3TSFxidh+V3jw0ntevA1j+LTHII5LcbiKreg9zMUTWb5hK913 f5Fp6+ZW+fN/pFUO9JE3dln5BTesu9R9ms90S6vVlFJjZWgL4cbx+GqSYQke8c52jB8= X-Gm-Gg: AZuq6aIGWUS3II+6AMGyZA1wcpZy/ErEx2ivSm7qSlZrRNxO5ART2MUyZEZ/ZAKiy4W msPPmxs+ujDvMEKGCXFrYIwBx5rkM1B1WafHiOnJDMXYaIe450nSwtBgsuTKC7ZLxxAGa6AW0Cs Mzl2Qedv9JrFDQAdMEm6vlCtOJdbhpSirgEVvX8667rXbHM0JU82Anz0dkRl+p5ndNOZtGjR1Pb Ih+VVTYoZEfQmFKOOU+wu5gyp3r2eqjS3+B/Tvsn5PQjVGTGhVO3P5p+TR+apriW9i5RmawMmE1 OZljeTL6oeZpOt8tr6Ke+a5+AApDyQAILg4Y3QYI+Vvx3NmJyOAQldrBXvoydVRHWM3p1FjkH+3 /vQHF/PtA15wmxDE/Iy+IscFbojSiXmltUUgmcjubrpsxgRm2DrIGcE4WrTVjV/EEDIPFY/xluT OcC+bfZX0Zm+1NGM+vX3Ool0rJC1yJJ/pLUDIXwGFegyo4NhY/Z+0FMqG6I0IGLlQ= X-Received: by 2002:a05:600c:34c7:b0:47d:25ac:3a94 with SMTP id 5b1f17b1804b1-4805cf5eb16mr69099575e9.17.1769428176854; Mon, 26 Jan 2026 03:49:36 -0800 (PST) Received: from ?IPV6:2001:a61:1306:1a01:7fb:321b:3b69:f667? ([2001:a61:1306:1a01:7fb:321b:3b69:f667]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-480470c1dc6sm318920465e9.10.2026.01.26.03.49.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jan 2026 03:49:36 -0800 (PST) Message-ID: <9239ddef-c197-4fbd-8e88-691766bda3e2@suse.com> Date: Mon, 26 Jan 2026 12:49:35 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 3/3] net: usb: kaweth: remove eth_addr_t typedef and bcast_addr definition To: Ethan Nelson-Moore , netdev@vger.kernel.org, linux-usb@vger.kernel.org Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni References: <20260125083501.34513-1-enelsonmoore@gmail.com> <20260125083501.34513-4-enelsonmoore@gmail.com> Content-Language: en-US From: Oliver Neukum In-Reply-To: <20260125083501.34513-4-enelsonmoore@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, unfortunately I must NACK this patch. Let me explain: On 25.01.26 09:34, Ethan Nelson-Moore wrote: > /**************************************************************** > * usb_eth_dev > ****************************************************************/ > @@ -185,7 +183,7 @@ struct kaweth_ethernet_configuration > __u8 size; > __u8 reserved1; > __u8 reserved2; > - eth_addr_t hw_addr; > + u8 hw_addr[ETH_ALEN]; You may note that this data structure is declared __packed and the member hw_addr is preceded by three members of type __u8. That means that it is located on a _three_ byte alignment. > __u32 statistics_mask; > __le16 segment_size; > __u16 max_multicast_filters; > @@ -882,7 +880,6 @@ static int kaweth_probe( [..] > @@ -991,9 +988,7 @@ static int kaweth_probe( > dev_info(dev, "MTU: %d\n", le16_to_cpu(kaweth->configuration.segment_size)); > dev_info(dev, "Read MAC address %pM\n", kaweth->configuration.hw_addr); > > - if(!memcmp(&kaweth->configuration.hw_addr, > - &bcast_addr, > - sizeof(bcast_addr))) { > + if (is_broadcast_ether_addr((const u8 *)&kaweth->configuration.hw_addr)) { Here you are using is_broadcast_ether_addr(). Let me quote from the documentation on this helper: /** * is_broadcast_ether_addr - Determine if the Ethernet address is broadcast * @addr: Pointer to a six-byte array containing the Ethernet address * * Return: true if the address is the broadcast address. * * Please note: addr must be aligned to u16. */ That requirement is not met. This code will bomb on ARM for example. HTH Oliver NACKED-BY: Oliver Neukum