netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jay Vosburgh <fubar@us.ibm.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Moni Shoua <monisonlists@gmail.com>,
	rdreier@cisco.com, netdev@vger.kernel.org,
	general@lists.openfabrics.org
Subject: [PATCH linux-2.6] bonding: two small fixes for IPoIB support
Date: Mon, 15 Oct 2007 16:44:27 -0700	[thread overview]
Message-ID: <9245.1192491867@death> (raw)
In-Reply-To: <4713E20F.9080305@pobox.com>


	Two small fixes to IPoIB support for bonding:

	1- copy header_ops from slave to bonding for IPoIB slaves
	2- move release and destroy logic to UNREGISTER from GOING_DOWN
	   notifier to avoid double release

	Set bonding to version 3.2.1.

Signed-off-by: Moni Shoua <monis at voltaire.com>
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>

---
 drivers/net/bonding/bond_main.c |   11 +++++------
 drivers/net/bonding/bonding.h   |    4 ++--
 2 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index db80f24..6f85cc3 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1263,6 +1263,7 @@ static void bond_setup_by_slave(struct net_device *bond_dev,
 	struct bonding *bond = bond_dev->priv;
 
 	bond_dev->neigh_setup           = slave_dev->neigh_setup;
+	bond_dev->header_ops		= slave_dev->header_ops;
 
 	bond_dev->type		    = slave_dev->type;
 	bond_dev->hard_header_len   = slave_dev->hard_header_len;
@@ -3351,7 +3352,10 @@ static int bond_slave_netdev_event(unsigned long event, struct net_device *slave
 	switch (event) {
 	case NETDEV_UNREGISTER:
 		if (bond_dev) {
-			bond_release(bond_dev, slave_dev);
+			if (bond->setup_by_slave)
+				bond_release_and_destroy(bond_dev, slave_dev);
+			else
+				bond_release(bond_dev, slave_dev);
 		}
 		break;
 	case NETDEV_CHANGE:
@@ -3366,11 +3370,6 @@ static int bond_slave_netdev_event(unsigned long event, struct net_device *slave
 		 * ... Or is it this?
 		 */
 		break;
-	case NETDEV_GOING_DOWN:
-		dprintk("slave %s is going down\n", slave_dev->name);
-		if (bond->setup_by_slave)
-			bond_release_and_destroy(bond_dev, slave_dev);
-		break;
 	case NETDEV_CHANGEMTU:
 		/*
 		 * TODO: Should slaves be allowed to
diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h
index a8bbd56..b818060 100644
--- a/drivers/net/bonding/bonding.h
+++ b/drivers/net/bonding/bonding.h
@@ -22,8 +22,8 @@
 #include "bond_3ad.h"
 #include "bond_alb.h"
 
-#define DRV_VERSION	"3.2.0"
-#define DRV_RELDATE	"September 13, 2007"
+#define DRV_VERSION	"3.2.1"
+#define DRV_RELDATE	"October 15, 2007"
 #define DRV_NAME	"bonding"
 #define DRV_DESCRIPTION	"Ethernet Channel Bonding Driver"
 
-- 
1.5.3.1


  reply	other threads:[~2007-10-15 23:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-15 16:00 [PATCH V7 0/8] net/bonding: ADD IPoIB support for the bonding driver Moni Shoua
2007-10-15 16:03 ` [ofa-general] [PATCH V7 1/8] IB/ipoib: Bound the net device to the ipoib_neigh structue Moni Shoua
2007-10-15 16:08 ` [ofa-general] [PATCH V7 0/8] net/bonding: ADD IPoIB support for the bonding driver Moni Shoua
2007-10-15 16:09 ` [ofa-general] [PATCH V7 2/8] IB/ipoib: Verify address handle validity on send Moni Shoua
2007-10-15 16:10 ` [PATCH V7 3/8] net/bonding: Enable bonding to enslave non ARPHRD_ETHER Moni Shoua
2007-10-15 16:11 ` [PATCH V7 4/8] net/bonding: Enable bonding to enslave netdevices not supporting set_mac_address() Moni Shoua
2007-10-15 16:12 ` [PATCH V7 5/8] net/bonding: Enable IP multicast for bonding IPoIB devices Moni Shoua
2007-10-15 16:13 ` [PATCH V7 6/8] net/bonding: Handlle wrong assumptions that slave is always an Ethernet device Moni Shoua
2007-10-15 16:13 ` PATCH V6 7/8] net/bonding: Delay sending of gratuitous ARP to avoid failure Moni Shoua
2007-10-15 16:14 ` [PATCH V7 8/8] net/bonding: Destroy bonding master when last slave is gone Moni Shoua
2007-10-15 18:23 ` [ofa-general] Re: [PATCH V7 0/8] net/bonding: ADD IPoIB support for the bonding driver Jeff Garzik
2007-10-15 20:34   ` Jay Vosburgh
2007-10-15 20:50     ` [ofa-general] " Jeff Garzik
2007-10-15 21:53       ` Jay Vosburgh
2007-10-15 21:56         ` Jeff Garzik
2007-10-15 23:44           ` Jay Vosburgh [this message]
2007-10-16  7:56             ` [PATCH linux-2.6] bonding: two small fixes for IPoIB support Moni Shoua
2007-10-17  1:15             ` [ofa-general] " Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9245.1192491867@death \
    --to=fubar@us.ibm.com \
    --cc=general@lists.openfabrics.org \
    --cc=jgarzik@pobox.com \
    --cc=monisonlists@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=rdreier@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).