From: "Bowers, AndrewX" <andrewx.bowers@intel.com>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>
Subject: RE: [Intel-wired-lan] [PATCH 2/7] i40e: Use scnprintf() for avoiding potential buffer overflow
Date: Mon, 16 Mar 2020 20:32:12 +0000 [thread overview]
Message-ID: <92500904ba1a4c91b5a1215d12266234@intel.com> (raw)
In-Reply-To: <20200311083745.17328-3-tiwai@suse.de>
-----Original Message-----
From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Takashi Iwai
Sent: Wednesday, March 11, 2020 1:38 AM
To: netdev@vger.kernel.org
Cc: intel-wired-lan@lists.osuosl.org; David S . Miller <davem@davemloft.net>
Subject: [Intel-wired-lan] [PATCH 2/7] i40e: Use scnprintf() for avoiding potential buffer overflow
Since snprintf() returns the would-be-output size instead of the actual output size, the succeeding calls may go beyond the given buffer limit. Fix it by replacing with scnprintf().
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: intel-wired-lan@lists.osuosl.org
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
next prev parent reply other threads:[~2020-03-16 20:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 8:37 [PATCH 0/7] net: Use scnprintf() for avoiding potential buffer overflow Takashi Iwai
2020-03-11 8:37 ` [PATCH 1/7] net: caif: " Takashi Iwai
2020-03-11 8:37 ` [PATCH 2/7] i40e: " Takashi Iwai
2020-03-16 20:32 ` Bowers, AndrewX [this message]
2020-03-11 8:37 ` [PATCH 3/7] mlx4: " Takashi Iwai
2020-03-11 8:37 ` [PATCH 4/7] nfp: " Takashi Iwai
2020-03-11 11:01 ` [oss-drivers] " Simon Horman
2020-03-11 21:44 ` Jakub Kicinski
2020-03-11 8:37 ` [PATCH 5/7] ionic: " Takashi Iwai
2020-03-11 11:01 ` [oss-drivers] " Simon Horman
2020-03-11 16:45 ` Shannon Nelson
2020-03-11 8:37 ` [PATCH 6/7] sfc: " Takashi Iwai
2020-03-12 9:53 ` Martin Habets
2020-03-12 11:38 ` Takashi Iwai
2020-03-11 8:37 ` [PATCH 7/7] netdevsim: " Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92500904ba1a4c91b5a1215d12266234@intel.com \
--to=andrewx.bowers@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).