From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konstantin Khorenko Subject: Re: [PATCH v2 1/2] net/sctp: Make wrappers for accessing in/out streams Date: Thu, 9 Aug 2018 11:39:08 +0300 Message-ID: <926150d0-646d-b2bd-03ba-995c2eb55b72@virtuozzo.com> References: <20180724173647.GA8881@localhost.localdomain> <20180803162102.19540-1-khorenko@virtuozzo.com> <20180803162102.19540-2-khorenko@virtuozzo.com> <20180803.125000.55557304308180305.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: marcelo.leitner@gmail.com, oleg.babin@gmail.com, netdev@vger.kernel.org, linux-sctp@vger.kernel.org, vyasevich@gmail.com, nhorman@tuxdriver.com, lucien.xin@gmail.com, aryabinin@virtuozzo.com To: David Miller , David Laight Return-path: Received: from mail-eopbgr60130.outbound.protection.outlook.com ([40.107.6.130]:1563 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727371AbeHILC4 (ORCPT ); Thu, 9 Aug 2018 07:02:56 -0400 In-Reply-To: <20180803.125000.55557304308180305.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On 08/03/2018 10:50 PM, David Miller wrote: > From: Konstantin Khorenko > Date: Fri, 3 Aug 2018 19:21:01 +0300 > >> +struct sctp_stream_out *sctp_stream_out(const struct sctp_stream *stream, >> + __u16 sid) >> +{ >> + return ((struct sctp_stream_out *)(stream->out)) + sid; >> +} >> + >> +struct sctp_stream_in *sctp_stream_in(const struct sctp_stream *stream, >> + __u16 sid) >> +{ >> + return ((struct sctp_stream_in *)(stream->in)) + sid; >> +} > > I agree with David that these should be in a header file, and marked > inline. David and David, sure, will move them, thank you!