From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next] dt-bindings: dsa: Remove unnecessary #address/#size-cells Date: Tue, 8 May 2018 13:58:12 -0700 Message-ID: <926828d5-477a-514f-ac54-42dc7a263f5a@gmail.com> References: <1525695471-19984-1-git-send-email-festevam@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: andrew@lunn.ch, robh+dt@kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, Fabio Estevam To: Fabio Estevam , davem@davemloft.net Return-path: Received: from mail-qt0-f193.google.com ([209.85.216.193]:34850 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754659AbeEHU6W (ORCPT ); Tue, 8 May 2018 16:58:22 -0400 In-Reply-To: <1525695471-19984-1-git-send-email-festevam@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 05/07/2018 05:17 AM, Fabio Estevam wrote: > From: Fabio Estevam > > If the example binding is used on a real dts file, the following DTC > warning is seen with W=1: > > arch/arm/boot/dts/imx6q-b450v3.dtb: Warning (avoid_unnecessary_addr_size): /mdio-gpio/switch@0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property > > Remove unnecessary #address-cells/#size-cells to improve the binding > document examples. In most cases this is unnecessary because the parent node is an MDIO, I2C or SPI controller, and those typically have #address-cells = <1> and #size-cells = <0> because of their specific binding, but this is not necessarily true if using e.g: a MMIO mapped Ethernet switch. With the particular example though, this appears fine: Reviewed-by: Florian Fainelli -- Florian